Bugfix when specifying CONFIG_FILE var #187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that there was a CONFIG_FILE variable, but it was unused. The scripts always try to source conf from
./vpn.conf(so relative to the current working directory). Modify scripts so that if CONFIG_FILE is specified, it will use it, otherwise, it will fallback to using the./vpn.conffrom the current working directly.Additionally, the instructions for wireguard mention a PreUp script, but its not in the example, so modified it.
This change should simplify a lot of the instructions in the README - you don't need to
cdbefore executing the updown script - basically making most of these one liners, and executable from anywhere. However, I didn't update all the references in case you want to keep it as is.