PBL-21894 Add color support for window layout editor#222
PBL-21894 Add color support for window layout editor#222
Conversation
|
I question your sense of colour. |
There was a problem hiding this comment.
OK, I've changed it everywhere
|
This has merge conflicts. |
|
Conflicts fixed! |
ide/static/ide/js/colour_picker.js
Outdated
There was a problem hiding this comment.
Move this inside the anonymous function (as the first statement).
|
The appearance of ActionBarLayer should be updated to match its 3.x appearance (a 30-pixel-wide bar down the side; you'll have to check icon positioning). |
|
Would you want to that to change depending on whether the user is working with 2.x or 3.x? |
|
Yes. |
|
Hmm, looking at it, it seems I never actually added anything to disable the colour features when making a 2.x project... |
|
OK, I've fixed the code issues, the ActionBarLayer display, and made the colour options SDK 3 only |
b6ee338 to
3c53206
Compare
|
I wonder if the various other globals you've added ( |
|
IB.Settings is a submodule like ResourceManager/etc. ColourEnabled I wasn't sure about, since it's effectively a constant for the lifetime of the page. |
|
|
|
Right, PBIs will work in the ActionBarLayer now, and I renamed ColourEnabled to colourEnabled. |
ide/static/ide/js/ib/utils.js
Outdated
There was a problem hiding this comment.
This should probably just be called gcolour.
c31cfc4 to
c4b389f
Compare
c4b389f to
d8b6553
Compare
Now it just needs a colour picker and aplite support.
d8b6553 to
7671639
Compare
This PR adds full support for colours to the Interface Builder, with fallbacks supported for B/W watches.