Add type hints and improve code style with ruff

Author: gmazoyer

docs/conf.py

@@ -1,4 +1,4 @@
-# -*- coding: utf-8 -*-
+# noqa: INP001
 #
 # pyixapi documentation build configuration file, created by
 # sphinx-quickstart on Sun Sep 18 18:31:27 2022.
@@ -16,12 +16,12 @@
 # add these directories to sys.path here. If the directory is relative to the
 # documentation root, use os.path.abspath to make it absolute, like shown here.
 #
-import os
 import sys
+from pathlib import Path
 
-from pkg_resources import get_distribution
+from pyixapi import __version__ as pyixapi_version
 
-sys.path.insert(0, os.path.abspath("../"))
+sys.path.insert(0, str(Path().parent.resolve()))
 
 
 # -- General configuration ------------------------------------------------
@@ -49,14 +49,14 @@
 
 # General information about the project.
 project = "pyixapi"
-copyright = "2012, Guillaume Mazoyer"
+copyright = "2022, Guillaume Mazoyer"
 author = "Guillaume Mazoyer"
 
 # The version info for the project you're documenting, acts as replacement for
 # |version| and |release|, also used in various other places throughout the
 # built documents.
 # The full version, including alpha/beta/rc tags.
-release = get_distribution("pyixapi").version
+release = pyixapi_version
 #
 # The short X.Y version.
 version = ".".join(release.split(".")[:2])

pyixapi/__init__.py

@@ -1,4 +1,4 @@
-from .core.api import API as api
+from .core.api import API as api  # noqa: N811
 from .core.api import __version__  # noqa: F401
 from .core.query import ContentError, RequestError
 

pyixapi/core/api.py

@@ -1,3 +1,5 @@
+from typing import Any
+
 import requests
 
 from pyixapi.core.endpoint import Endpoint
@@ -32,7 +34,7 @@
 __version__ = "0.2.2"
 
 
-class API(object):
+class API:
     """
     The API object is the entrypoint for pyixapi.
 
@@ -42,13 +44,13 @@ class API(object):
 
     def __init__(
         self,
-        url,
-        key,
-        secret,
-        access_token="",
-        refresh_token="",
-        user_agent=f"pyixapi/{__version__}",
-    ):
+        url: str,
+        key: str,
+        secret: str,
+        access_token: str = "",
+        refresh_token: str = "",
+        user_agent: str = f"pyixapi/{__version__}",
+    ) -> None:
         self.url = url.rstrip("/")
         self.key = key
         self.secret = secret
@@ -90,7 +92,7 @@ def __init__(
         self.role_assignments = Endpoint(self, "role-assignments", model=RoleAssignment)
 
     @property
-    def version(self):
+    def version(self) -> int:
         """
         Get the API version of IX-API.
         """
@@ -99,20 +101,20 @@ def version(self):
         ).get_version()
 
     @property
-    def accounts(self):
+    def accounts(self) -> Endpoint:
         return Endpoint(
             self, "customers" if self.version == 1 else "accounts", model=Account
         )
 
     @property
-    def product_offerings(self):
+    def product_offerings(self) -> Endpoint:
         return Endpoint(
             self,
             "products" if self.version == 1 else "product-offerings",
             model=ProductOffering,
         )
 
-    def authenticate(self):
+    def authenticate(self) -> Record:
         """
         Authenticate and generate a pair of tokens.
 
@@ -139,7 +141,7 @@ def authenticate(self):
 
         return Record(r, self, self.auth)
 
-    def refresh_authentication(self):
+    def refresh_authentication(self) -> Record:
         """
         Prolong authentication by refreshing the tokens pair.
         """
@@ -154,7 +156,7 @@ def refresh_authentication(self):
 
         return Record(r, self, self.auth)
 
-    def health(self):
+    def health(self) -> dict[str, Any]:
         """
         Get the health information from IX-API.
 

pyixapi/core/endpoint.py

@@ -1,26 +1,32 @@
+from http import HTTPStatus
+from typing import TYPE_CHECKING
+
 from pyixapi.core.query import Request, RequestError
 from pyixapi.core.response import Record, RecordSet
 from pyixapi.core.util import cat
 
+if TYPE_CHECKING:
+    from .api import API
+
 
-class Endpoint(object):
+class Endpoint:
     """
     Represent actions available on endpoints in the IX-API.
 
     Build the correct URL to make queries and the proper :py:class:`.Response`
     object.
     """
 
-    def __init__(self, api, name, model=None):
+    def __init__(self, api: "API", name: str, model: Record | None = None) -> None:
         self.return_obj = model if model else Record
         self.api = api
         self.url = cat(api.url, name)
         self.name = name
 
-    def __str__(self):
+    def __str__(self) -> str:
         return self.url
 
-    def all(self):
+    def all(self) -> RecordSet:
         """
         Return all objects from an endpoint.
         """
@@ -31,7 +37,7 @@ def all(self):
         )
         return RecordSet(self, r)
 
-    def filter(self, *args, **kwargs):
+    def filter(self, *args, **kwargs) -> RecordSet:
         """
         Query the list of a given endpoint. Also take named arguments that match the
         usable filters on a given endpoint.
@@ -44,7 +50,7 @@ def filter(self, *args, **kwargs):
         )
         return RecordSet(self, r)
 
-    def get(self, *args, **kwargs):
+    def get(self, *args, **kwargs) -> Record | None:
         """
         Return a single object from an endpoint.
         """
@@ -78,12 +84,12 @@ def get(self, *args, **kwargs):
         try:
             return next(RecordSet(self, r), None)
         except RequestError as e:
-            if e.req.status_code == 404:
+            if e.req.status_code == HTTPStatus.NOT_FOUND:
                 return None
-            else:
-                raise e
 
-    def create(self, *args, **kwargs):
+            raise e
+
+    def create(self, *args, **kwargs) -> Record:
         """
         Creates an object on an endpoint.