Skip to content

exclude bulk actions#2240

Merged
notAreYouScared merged 2 commits intopelican-dev:mainfrom
hallo123wert:action
Feb 16, 2026
Merged

exclude bulk actions#2240
notAreYouScared merged 2 commits intopelican-dev:mainfrom
hallo123wert:action

Conversation

@hallo123wert
Copy link
Contributor

@hallo123wert hallo123wert commented Feb 15, 2026

  • Roles List
  • Webhooks List
  • Mounts List
  • Database List

@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2026

📝 Walkthrough

Walkthrough

DeleteBulkAction invocations in several Filament resource table configurations were changed to pass the identifier 'exclude_bulk_delete' where they previously had no arguments; no other behavioral changes were introduced.

Changes

Cohort / File(s) Summary
Bulk Delete Action Configuration
app/Filament/Admin/Resources/Roles/RoleResource.php, app/Filament/Admin/Resources/DatabaseHosts/DatabaseHostResource.php, app/Filament/Admin/Resources/Mounts/MountResource.php, app/Filament/Admin/Resources/Webhooks/WebhookResource.php
Replaced DeleteBulkAction::make() with DeleteBulkAction::make('exclude_bulk_delete') in each resource's table/bulk actions configuration. Review toolbar/bulk-action identifiers where referenced.

Possibly related PRs

  • Fix more actions #2208 — Matches code-level changes renaming bulk-delete action identifiers to use the "exclude_" prefixed name.
  • More action fixes #2237 — Similar renaming of action identifiers to an "exclude_*" prefix across actions (consistent identifier convention).
🚥 Pre-merge checks | ✅ 1 | ❌ 3
❌ Failed checks (1 warning, 2 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'exclude bulk actions' is vague and does not clearly convey the specific change being made across the files. Use a more descriptive title that clarifies the purpose, such as 'Add identifiers to DeleteBulkAction across resources' or 'Configure bulk delete actions with exclude identifier'.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a description explaining why the 'exclude_bulk_delete' identifier is being added to DeleteBulkAction calls and what behavior or functionality this enables.
✅ Passed checks (1 passed)
Check name Status Explanation
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@app/Filament/Admin/Resources/Roles/RoleResource.php`:
- Line 109: The bulk-delete action was only renamed via
DeleteBulkAction::make('exclude_bulk_delete') which does not hide or disable it;
update the Roles resource to actually remove or hide the bulk delete by either
removing the BulkActionGroup that contains DeleteBulkAction, or call the
action's visibility/authorization helpers (e.g., use ->hidden(fn() => true) or
->authorization(fn($user) => false) on the DeleteBulkAction instance) so the
delete button is not shown for the RoleResource list; refer to
DeleteBulkAction::make(...) and the BulkActionGroup in the Roles resource and
the CanModifyTable trait when making this change.

@hallo123wert hallo123wert changed the title exclude bulk actions in list roles exclude bulk actions Feb 15, 2026
@notAreYouScared notAreYouScared merged commit 0918ed3 into pelican-dev:main Feb 16, 2026
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2026
@hallo123wert hallo123wert deleted the action branch February 16, 2026 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants