removed unnecessary fns from this pr

Peter Alfonsi · Peter Alfonsi · commit c0b3dd223329 · 2024-04-11T15:13:57.000-07:00
Signed-off-by: Peter Alfonsi &lt;petealft@amazon.com&gt;
diff --git a/server/src/main/java/org/opensearch/common/cache/stats/MultiDimensionCacheStats.java b/server/src/main/java/org/opensearch/common/cache/stats/MultiDimensionCacheStats.java
@@ -91,10 +91,6 @@ static class MDCSDimensionNode {
             this.stats = stats;
         }
 
-        MDCSDimensionNode(String dimensionValue, boolean createChildrenMap) {
-            this(dimensionValue, createChildrenMap, null);
-        }
-
         Map<String, MDCSDimensionNode> getChildren() {
             return children;
         }
diff --git a/server/src/main/java/org/opensearch/common/cache/stats/StatsHolder.java b/server/src/main/java/org/opensearch/common/cache/stats/StatsHolder.java
@@ -176,8 +176,7 @@ private void getCacheStatsHelper(DimensionNode currentNodeInOriginalTree, MDCSDi
     private MDCSDimensionNode createMatchingMDCSDimensionNode(DimensionNode node) {
         CacheStatsCounterSnapshot nodeSnapshot = node.getStatsSnapshot();
         boolean isLeafNode = node.getChildren().isEmpty();
-        MDCSDimensionNode newNode = new MDCSDimensionNode(node.getDimensionValue(), !isLeafNode, nodeSnapshot);
-        return newNode;
+        return new MDCSDimensionNode(node.getDimensionValue(), !isLeafNode, nodeSnapshot);
     }
 
     public void removeDimensions(List<String> dimensionValues) {

Original file line number	Diff line number	Diff line change
`@@ -91,10 +91,6 @@ static class MDCSDimensionNode {`
`91`	`91`	`this.stats = stats;`
`92`	`92`	`}`
`93`	`93`
`94`		`- MDCSDimensionNode(String dimensionValue, boolean createChildrenMap) {`
`95`		`- this(dimensionValue, createChildrenMap, null);`
`96`		`- }`
`97`		`-`
`98`	`94`	`Map<String, MDCSDimensionNode> getChildren() {`
`99`	`95`	`return children;`
`100`	`96`	`}`
Original file line number	Diff line number	Diff line change
`@@ -176,8 +176,7 @@ private void getCacheStatsHelper(DimensionNode currentNodeInOriginalTree, MDCSDi`
`176`	`176`	`private MDCSDimensionNode createMatchingMDCSDimensionNode(DimensionNode node) {`
`177`	`177`	`CacheStatsCounterSnapshot nodeSnapshot = node.getStatsSnapshot();`
`178`	`178`	`boolean isLeafNode = node.getChildren().isEmpty();`
`179`		`- MDCSDimensionNode newNode = new MDCSDimensionNode(node.getDimensionValue(), !isLeafNode, nodeSnapshot);`
`180`		`- return newNode;`
	`179`	`+ return new MDCSDimensionNode(node.getDimensionValue(), !isLeafNode, nodeSnapshot);`
`181`	`180`	`}`
`182`	`181`
`183`	`182`	`public void removeDimensions(List<String> dimensionValues) {`