Fix error on create_vanadium if no sample details in ISIS powder reduction (mantidproject#38399)

* Check if not vanadium before throw error for no sample details

* Add unit test for check sample details

* Add release note

Author: RichardWaiteSTFC

docs/source/release/v6.12.0/Diffraction/Powder/Bugfixes/38399.rst

@@ -0,0 +1 @@
+- Fix bug where unable to call `create_vanadium` without setting sample details in :ref:`ISIS Powder Diffraction Scripts <isis-powder-diffraction-ref>`.

scripts/Diffraction/isis_powder/abstract_inst.py

@@ -198,7 +198,8 @@ def _generate_input_file_name(self, run_number, file_ext=None):
         return self._generate_inst_filename(run_number=run_number, file_ext=file_ext)
 
     def _check_sample_details(self):
-        if self._sample_details is None:
+        # note vanadium sample details are set using advanced configs
+        if self._sample_details is None and not self._is_vanadium:
             raise ValueError(
                 "Absorption corrections cannot be run without sample details."
                 " Please set sample details using set_sample before running absorption corrections."

scripts/Diffraction/isis_powder/test/ISISPowderAbstractInstrumentTest.py

@@ -274,6 +274,18 @@ def test_output_focused_runs_summed_batch_mode(
         expected_calls = 2 * [call(d_spacing_group=run_string, tof_group=run_string, unit_to_keep=None)]
         mock_keep_unit.assert_has_calls(expected_calls)
 
+    def test_check_sample_details_is_vanadium(self):
+        mock_inst = self._setup_mock_inst(calibration_dir="ignored", output_dir="ignored", yaml_file_path="ISISPowderRunDetailsTest.yaml")
+        mock_inst._is_vanadium = True
+        mock_inst._sample_details = None
+        mock_inst._check_sample_details()  # does not throw
+
+    def test_check_sample_details_is_not_vanadium(self):
+        mock_inst = self._setup_mock_inst(calibration_dir="ignored", output_dir="ignored", yaml_file_path="ISISPowderRunDetailsTest.yaml")
+        mock_inst._is_vanadium = False
+        mock_inst._sample_details = None
+        self.assertRaises(ValueError, mock_inst._check_sample_details)
+
 
 if __name__ == "__main__":
     unittest.main()