From a2634bd5ddc1d21de3c632dfb93c7e208e01a281 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Artjoms=20I=C5=A1kovs?= <mildbyte@gmail.com>
Date: Mon, 5 Jan 2026 14:46:10 +0200
Subject: [PATCH] fix: use same profile for embed binary to avoid double
 compilation

`second_build` and `compute_sql` always use the dev/debug profile for
the pgrx_embed binary, regardless of the profile used for the main
extension build.

This causes cargo to recompile the entire dependency tree in debug mode
even when the extension had already been compiled in release mode.

When compiling an extension in release mode, this results in:
- A release compilation
- Another debug compilation
- Debug artifacts often larger than release artifacts
- CI cache bloat (sccache/GHA cache has to store these debug artifacts)

Now the embed binary uses the same profile as the library build,
allowing cargo to reuse artifacts from the first build. The second
compilation now only links the small pgrx_embed binary itself.

This shouldn't change the dev experience, where both the extension and
the embed binary will compile in the debug mode.
---
 cargo-pgrx/src/command/schema.rs | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/cargo-pgrx/src/command/schema.rs b/cargo-pgrx/src/command/schema.rs
index d9ec0bd4ad..8498136c6d 100644
--- a/cargo-pgrx/src/command/schema.rs
+++ b/cargo-pgrx/src/command/schema.rs
@@ -207,9 +207,9 @@ pub(crate) fn generate_schema_implicit(
         tracing::info!(dot = %dot_path.display(), "Writing Graphviz DOT");
     }
 
-    second_build(cargo, &features_arg, embed.path(), &manifest)?;
+    second_build(cargo, &features_arg, embed.path(), &manifest, profile)?;
 
-    compute_sql(&manifest)?;
+    compute_sql(&manifest, profile)?;
 
     Ok(())
 }
@@ -452,6 +452,7 @@ fn second_build(
     features_arg: &str,
     embed_path: &Path,
     manifest: &Manifest,
+    profile: &CargoProfile,
 ) -> eyre::Result<()> {
     // We do pass cfg to the binary and do not pass cfg to dependencies to avoid recompilation
     // The only cargo command respecting our need is `cargo rustc`
@@ -460,6 +461,8 @@ fn second_build(
         .flag_args("--bin", vec![pgrx_embed_name(manifest)?])
         .into_command();
 
+    command.args(profile.cargo_args());
+
     command.arg("--");
 
     command.args(["--cfg", "pgrx_embed"]);
@@ -468,7 +471,7 @@ fn second_build(
 
     let command_str = format!("{command:?}");
     eprintln!(
-        "{} {}, in debug mode, for SQL generation with features {}",
+        "{} {} for SQL generation with features {}",
         "  Rebuilding".bold().green(),
         "pgrx_embed".cyan(),
         features_arg.cyan(),
@@ -487,9 +490,9 @@ fn second_build(
     Ok(())
 }
 
-fn compute_sql(manifest: &Manifest) -> eyre::Result<()> {
+fn compute_sql(manifest: &Manifest, profile: &CargoProfile) -> eyre::Result<()> {
     let mut bin = get_target_dir()?;
-    bin.push("debug"); // pgrx_embed_ is always compiled in debug mode
+    bin.push(profile.target_subdir());
     bin.push(pgrx_embed_name(manifest)?);
 
     let mut command = std::process::Command::new(bin);