Codestyle fixes

Author: BeMySlaveDarlin

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,26 @@
+> Questions should go to https://forum.phalcon.io
+> Documentation issues should go to https://github.com/phalcon/docs/issues
+
+### Expected and Actual Behavior
+
+> **Describe what you are trying to achieve and what goes wrong.**
+
+> Provide output if related
+
+```php
+// paste output here
+```
+> Provide minimal script to reproduce the issue
+
+```php
+// paste code
+```
+
+### Details
+
+* System info and versions (if possible): (`phalcon info`)
+* Phalcon Framework version: (`php --ri phalcon`)
+* PHP Version: (`php -v`)
+* Operating System:
+* Server: Nginx | Apache | Other
+* Other related info (Database, table schema):

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,16 @@
+Hello!
+
+* Type: bug fix | new feature | code quality | documentation
+* Link to issue:
+
+**In raising this pull request, I confirm the following (please check boxes):**
+
+- [ ] I have read and understood the [Contributing Guidelines][:contrib:]
+- [ ] I have checked that another pull request for this purpose does not exist
+- [ ] I wrote some tests for this PR
+
+Small description of change:
+
+Thanks
+
+[:contrib:]: https://github.com/phalcon/migrations/blob/master/CONTRIBUTING.md

CONTRIBUTING.md

@@ -0,0 +1,65 @@
+# Contributing to Phalcon Migrations Utility
+
+Phalcon Migrations Utility is an open source project and a volunteer effort.
+Phalcon Migrations Utility welcomes contribution from everyone.
+
+## Contributions
+
+Contributions to Phalcon Migrations Utility should be made in the form of [GitHub pull requests][pr].
+Each pull request will be reviewed by a core contributor (someone with permission to land patches) and either landed in
+the main tree or given feedback for changes that would be required before it can be merged. All contributions should
+follow this format, even those from core contributors.
+
+## Questions & Support
+
+*We only accept bug reports, new feature requests and pull requests in GitHub*.
+For questions regarding the usage of the Phalcon Migrations Utility or support requests please visit the
+[official forums][forum]. IDE stubs must not be modified manually, if you want to improve them please submit a PR
+to [Phalcon Framework][cphalcon].
+
+## Bug Report Checklist
+
+- Make sure you are using the latest released version of Phalcon Framework and Phalcon Migrations Utility
+  before submitting a bug report. Bugs in versions older than the latest released one will not be addressed by the
+  core team
+
+- If you have found a bug it is important to add relevant reproducibility information to your issue to allow us 
+  to reproduce the bug and fix it quicker. Add a script, small program or repository providing the necessary code to 
+  make everyone reproduce the issue reported easily. If a bug cannot be reproduced by the development it would be
+  difficult provide corrections and solutions. [Submit Reproducible Test][srt] for more information.
+
+- Be sure that information such as OS, Phalcon Framework and Phalcon Migrations Utility versions and PHP version are
+  part of the bug report
+
+- If you're submitting a Segmentation Fault error, we would require a backtrace, please see [Generating a Backtrace][gb]
+
+## Pull Request Checklist
+
+- Don't submit your pull requests to the `master` branch. Branch from the required branch and,
+  if needed, rebase to the proper branch before submitting your pull request.
+  If it doesn't merge cleanly with master you may be asked to rebase your changes
+  
+- Don't put submodule updates, composer.lock, etc in your pull request unless they are to landed commits
+
+- Make sure that the code you write fits with the general style and coding standards of the [Accepted PHP Standards][psr]
+
+## Getting Support
+
+If you have a question about how to use Phalcon, please see the [support page][support].
+
+## Requesting Features
+
+If you have a change or new feature in mind, please fill an [NFR][nfr].
+
+Thanks! <br />
+Phalcon Team
+
+
+[pr]: https://help.github.com/articles/about-pull-requests/
+[forum]: https://forum.phalcon.io/
+[cphalcon]: https://github.com/phalcon/cphalcon
+[srt]: https://docs.phalcon.io/en/latest/reproducible-tests
+[gb]: https://docs.phalcon.io/en/latest/generating-backtrace
+[support]: https://phalcon.io/en/support/
+[nfr]: https://docs.phalcon.io/en/latest/new-feature-request
+[psr]: https://www.php-fig.org/psr/

composer.json

@@ -42,6 +42,7 @@
         "codeception/module-cli": "^1.0",
         "codeception/module-phpbrowser": "^1.0.0",
         "codeception/module-db": "^1.0",
+        "vimeo/psalm": "^4.6",
         "vlucas/phpdotenv": "^4.1"
     },
     "autoload": {

src/Console/Commands/Migration.php

@@ -86,13 +86,14 @@ public function run(): void
         } else {
             $config = $this->getConfig($path);
         }
+        $application = $config->get('application') ?? [];
 
         // Multiple dir
         $migrationsDir = [];
         if ($this->parser->has('migrations')) {
             $migrationsDir = explode(',', $this->parser->get('migrations'));
-        } elseif (isset($config['application']['migrationsDir'])) {
-            $migrationsDir = explode(',', $config['application']['migrationsDir']);
+        } elseif (isset($application['migrationsDir'])) {
+            $migrationsDir = explode(',', $application['migrationsDir']);
         }
 
         if (!empty($migrationsDir)) {
@@ -113,19 +114,20 @@ public function run(): void
          * Keep migrations log in db either "log-in-db" option or "logInDb"
          * config variable from "application" block
          */
-        $migrationsInDb = $config['application']['logInDb'] ?? $this->parser->has('log-in-db');
+        $migrationsInDb = $application['logInDb'] ?? $this->parser->has('log-in-db');
 
         /**
          * Migrations naming is timestamp-based rather than traditional, dotted versions
          * either "ts-based" option or "migrationsTsBased" config variable from "application" block
          */
-        $migrationsTsBased = $config['application']['migrationsTsBased'] ?? $this->parser->has('ts-based');
+        $migrationsTsBased = $application['migrationsTsBased'] ?? $this->parser->has('ts-based');
 
-        $noAutoIncrement = $config['application']['no-auto-increment'] ?? $this->parser->has('no-auto-increment');
-        $skipRefSchema = $config['application']['skip-ref-schema'] ?? $this->parser->has('skip-ref-schema');
-        $skipForeignChecks = $config['application']['skip-foreign-checks'] ?? $this->parser->has('skip-foreign-checks');
 
-        $descr = $config['application']['descr'] ?? $this->parser->get('descr');
+        $noAutoIncrement = $application['no-auto-increment'] ?? $this->parser->has('no-auto-increment');
+        $skipRefSchema = $application['skip-ref-schema'] ?? $this->parser->has('skip-ref-schema');
+        $skipForeignChecks = $application['skip-foreign-checks'] ?? $this->parser->has('skip-foreign-checks');
+
+        $descr = $application['descr'] ?? $this->parser->get('descr');
         $tableName = $this->parser->get('table', '@');
 
         switch ($action) {
@@ -210,11 +212,12 @@ public function getHelp(): void
     protected function exportFromTables($config): array
     {
         $tables = [];
+        $application = $config->get('application') ?? [];
 
         if ($this->parser->has('exportDataFromTables')) {
             $tables = explode(',', $this->parser->get('exportDataFromTables'));
-        } elseif (isset($config['application']['exportDataFromTables'])) {
-            $configTables = $config['application']['exportDataFromTables'];
+        } elseif (isset($application['exportDataFromTables'])) {
+            $configTables = $application['exportDataFromTables'];
             if ($configTables instanceof Config) {
                 $tables = $configTables->toArray();
             } else {

src/Migrations.php

@@ -333,13 +333,15 @@ public static function run(array $options)
             ) {
                 continue;
             }
-            if ((ModelMigration::DIRECTION_FORWARD === $direction)
+            if (
+                ModelMigration::DIRECTION_FORWARD === $direction
                 && isset($completedVersions[(string)$versionItem])
             ) {
                 print Color::info('Version ' . (string)$versionItem . ' was already applied');
                 continue;
             }
-            if ((ModelMigration::DIRECTION_BACK === $direction)
+            if (
+                ModelMigration::DIRECTION_BACK === $direction
                 && !isset($completedVersions[(string)$initialVersion])
             ) {
                 print Color::info('Version ' . (string)$initialVersion . ' was already rolled back');

src/Mvc/Model/Migration.php

@@ -697,15 +697,17 @@ public function morphTable(string $tableName, array $definition): void
                     $changed = true;
                 }
 
-                if (!$changed &&
-                    count($tableReference->getColumns()) !==
+                if (
+                    !$changed
+                    && count($tableReference->getColumns()) !==
                     count($localReferences[$tableReference->getName()]['columns'])
                 ) {
                     $changed = true;
                 }
 
-                if (!$changed &&
-                    count($tableReference->getReferencedColumns()) !==
+                if (
+                    !$changed
+                    && count($tableReference->getReferencedColumns()) !==
                     count($localReferences[$tableReference->getName()]['referencedColumns'])
                 ) {
                     $changed = true;
@@ -722,7 +724,8 @@ public function morphTable(string $tableName, array $definition): void
 
                 if (!$changed) {
                     foreach ($tableReference->getReferencedColumns() as $columnName) {
-                        if (!in_array($columnName, $localReferences[$tableReference->getName()]['referencedColumns'], true)) {
+                        $referencedColumns = $localReferences[$tableReference->getName()]['referencedColumns'];
+                        if (!in_array($columnName, $referencedColumns, true)) {
                             $changed = true;
                             break;
                         }