Skip to content

Conversation

@arbi316
Copy link

@arbi316 arbi316 commented Aug 12, 2018

also tweaked spells for BfA optimizing

A bug that doesn't work is fixed and Healing Tide Totem works also tweaks some spells
@Phanx
Copy link
Member

Phanx commented Aug 19, 2018

Thanks for the PR. Unfortunately there are several issues that need to be resolved before it can be considered:

  1. Please restore the original LF (not CRLF) line endings. Currently the diffs cover 100% of the files and it's impossible to see what actually changed.

  2. Please remove the .gitattributes file. I don't want this in the repo. 99% of it is specific to file types that will never exist a WoW addon, and where it does specify a line ending style, it doesn't match the one used in the addon already. Setting git config core.autocrlf appropriately for your platform, and (optionally but ideally) configuring your editor not to clobber the line endings in existing files in the first place, is a better solution that doesn't require extra stuff in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants