Skip to content

Using observation space dimension size for the Actor and Critic models. #40

Open
@toohsk

Description

@toohsk

Hi, @philtabor !

Thanks for the awesome code and video!
Those really help me to study and understand reinforcement learning.

I found that the actor and critic model are not using observation space dim as their input_dim.
Shouldn't it be the same dim size as observation space?

What do you think?

And I made a pull request #39 about above.
I really appreciate your review!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions