Conversation
… into issue-38-fix-search-class-in-the-same-namespace
5f11244 to
1cc81b7
Compare
…p (that should act as example of extending and override)
|
@nick-zh, please look I've fixed almost all tests, but there still 2 failed like: But that related to the public int|string $blaaaaaaaa;That use Union type declaration which is available since PHP 8.0.0. |
|
I think it is ok for 3.x to drop |
…alizing compare
…lassPropertyTypeItem::jsonSerialize in tests
…lassPropertyTypeItem::jsonSerialize in tests
|
All tests passed now. There is coverage below 100% thought. Please say if you are generally willing to accept such PR and I could continue work to extend coverage and deal with some code-style warnings. Or we wait your refactoring in terms of #49? |
|
Yeah might be best to maybe hold of for the moment, since some changes / renaming might complicate things unnecessarily for you. Sry for the inconvenience. I hope i can tackle this next weekend. I already started, but still need to figure out some stuff |
Major refactoring with PhpClassPropertyType typing
Closes #33