Skip to content

Conversation

jcstang
Copy link

@jcstang jcstang commented Jun 13, 2025

added a docker compose option when upgrading.

Description

Added a line that talked about docker compose.

Motivation and Context

Clarify for users like me who use docker compose vs docker run.

How Has This Been Tested?

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • na

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

added a docker compose option when upgrading.

Signed-off-by: jcstang <devjake@outlook.com>
@jcstang jcstang requested a review from a team as a code owner June 13, 2025 18:47
Do not attempt to upgrade (`pihole -up`) or reconfigure (`pihole -r`).

New images will be released for upgrades, upgrading by replacing your old container with a fresh upgraded image is the 'docker way'. Long-living docker containers are not the docker way since they aim to be portable and reproducible, why not re-create them often! Just to prove you can.
New images will be released for upgrades, upgrading by replacing your old container with a fresh upgraded image is the 'docker way'. Long-living docker containers are not the docker way since they aim to be portable and reproducible, why not re-create them often! **Just to prove you can.**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the styling here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just meant to change the styling for "Just to prove you can.". Thought an emphasis on this phrase would be impactful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
New images will be released for upgrades, upgrading by replacing your old container with a fresh upgraded image is the 'docker way'. Long-living docker containers are not the docker way since they aim to be portable and reproducible, why not re-create them often! **Just to prove you can.**
New images will be released for upgrades, upgrading by replacing your old container with a fresh upgraded image is the 'docker way'. Long-living docker containers are not the docker way since they aim to be portable and reproducible, why not re-create them often!

I think this could even be removed.

jcstang and others added 2 commits June 17, 2025 12:32
Co-authored-by: yubiuser <github@yubiuser.dev>
Signed-off-by: jcstang <devjake@outlook.com>
- This will help you avoid common problems due to any known issues with upgrading or newly required arguments or variables
- We will try to put common break/fixes at the top of this readme too
1. Download the latest version of the image: `docker pull pihole/pihole`
2. Throw away your container: `docker rm -f pihole`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Throw away your container: `docker rm -f pihole`
2. Throw away your container: `docker compose down`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably switch this up for a compose command, too. Otherwise it doesn't make a lot of sense in the grand scheme of things.

Copy link
Member

@rdwebdesign rdwebdesign Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm undecided here... We have a few places suggesting docker run commands and arguments in the Docs and in the README:

Maybe we could suggest both commands:

Suggested change
2. Throw away your container: `docker rm -f pihole`
2. Throw away your container: `docker rm -f pihole` or `docker compose down`, depending on how you started your container.

And also change the step 3., adding:

-3. Start your container with the newer base image: `docker compose up -d` 
+3. Start your container with the newer base image: `docker compose up -d` or `docker run <args>`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would switch everything to compose syntax. Are users really running docker run by hand with all the necessary options/flags?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are users really running docker run

The trick is never to be surprised, and then they cannot surprise you.

Copy link
Contributor

@casperklein casperklein Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can avoid the docker compose down step by using: docker compose pull && docker compose up --force-recreate

https://docs.docker.com/reference/cli/docker/compose/up/

Edit:

Or as a one-liner: docker compose up --force-recreate --pull always -d

This downloads the latest image, stops and removes the currently running container, creates a new one, and starts it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants