Add tests for fractional width in SVGs

Author: casperbakker

generate-verified-files.php

@@ -8,6 +8,7 @@ function getSaveFilename($value) {
 
 $generatorSVG = new Picqer\Barcode\BarcodeGeneratorSVG();
 file_put_contents('tests/verified-files/081231723897-ean13.svg', $generatorSVG->getBarcode('081231723897', $generatorSVG::TYPE_EAN_13));
+file_put_contents('tests/verified-files/081231723897-ean13-fractional-width.svg', $generatorSVG->getBarcode('081231723897', $generatorSVG::TYPE_EAN_13, 0.25, 25.75));
 
 $generatorHTML = new Picqer\Barcode\BarcodeGeneratorHTML();
 file_put_contents('tests/verified-files/081231723897-code128.html', $generatorHTML->getBarcode('081231723897', $generatorHTML::TYPE_CODE_128));

src/BarcodeGeneratorSVG.php

@@ -10,17 +10,22 @@ class BarcodeGeneratorSVG extends BarcodeGenerator
      * @param $barcode (string) code to print
      * @param BarcodeGenerator::Type_* $type (string) type of barcode
      * @param $widthFactor (float) Minimum width of a single bar in user units.
-     * @param $height (int) Height of barcode in user units.
+     * @param $height (float) Height of barcode in user units.
      * @param $foregroundColor (string) Foreground color (in SVG format) for bar elements (background is transparent).
      * @return string SVG code.
      * @public
      */
-    public function getBarcode(string $barcode, $type, float $widthFactor = 2, int $height = 30, string $foregroundColor = 'black')
+    public function getBarcode(string $barcode, $type, float $widthFactor = 2, float $height = 30, string $foregroundColor = 'black')
     {
         $barcodeData = $this->getBarcodeData($barcode, $type);
 
         // replace table for special characters
-        $repstr = ["\0" => '', '&' => '&amp;', '<' => '&lt;', '>' => '&gt;'];
+        $repstr = [
+            "\0" => '',
+            '&' => '&amp;',
+            '<' => '&lt;',
+            '>' => '&gt;',
+        ];
 
         $width = round(($barcodeData->getWidth() * $widthFactor), 3);
 
@@ -45,6 +50,7 @@ public function getBarcode(string $barcode, $type, float $widthFactor = 2, int $
 
             $positionHorizontal += $barWidth;
         }
+
         $svg .= "\t</g>" . PHP_EOL;
         $svg .= '</svg>' . PHP_EOL;
 

tests/BarcodeSvgTest.php

@@ -11,4 +11,12 @@ public function test_svg_barcode_generator_can_generate_ean_13_barcode()
 
         $this->assertStringEqualsFile('tests/verified-files/081231723897-ean13.svg', $generated);
     }
+
+    public function test_svg_barcode_generator_can_generate_ean_13_barcode_with_fractional_width()
+    {
+        $generator = new Picqer\Barcode\BarcodeGeneratorSVG();
+        $generated = $generator->getBarcode('081231723897', $generator::TYPE_EAN_13, 0.25, 25.75);
+
+        $this->assertStringEqualsFile('tests/verified-files/081231723897-ean13-fractional-width.svg', $generated);
+    }
 }