Skip to content

Commit 21c809d

Browse files
committed
Add protection against deref of NULL set
1 parent e523727 commit 21c809d

File tree

1 file changed

+17
-11
lines changed
  • customer_app/bl602_demo_event/bl602_demo_event

1 file changed

+17
-11
lines changed

customer_app/bl602_demo_event/bl602_demo_event/ble.c

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
#if defined(CONFIG_BT_WIFIPROV_SERVER)
7070
static void wifiprov_connect_ap_ind(void)
7171
{
72-
printf("Recevied indication to connect to AP\r\n");
72+
printf("Recevied indication to connect to AP\r\n");
7373
wifi_prov_api_event_trigger_connect();
7474
}
7575

@@ -87,7 +87,7 @@ static void wifiprov_ssid_ind(void *buf,size_t size)
8787

8888
static void wifiprov_bssid_ind(void *buf,size_t size)
8989
{
90-
90+
9191
printf("Recevied bssid: %s \r\n", bt_hex(buf, size));
9292
}
9393

@@ -115,7 +115,7 @@ struct conn_callback WifiProv_conn_callback = {
115115

116116
void model_gen_cb(uint8_t value)
117117
{
118-
bl_gpio_output_set(LED_PIN, value);
118+
bl_gpio_output_set(LED_PIN, value);
119119
}
120120

121121
#if defined(CONFIG_BT_MESH_MODEL)
@@ -132,6 +132,9 @@ static void example_handle_gen_onoff_msg(bfl_ble_mesh_model_t *model,
132132
break;
133133
case BFL_BLE_MESH_MODEL_OP_GEN_ONOFF_SET:
134134
case BFL_BLE_MESH_MODEL_OP_GEN_ONOFF_SET_UNACK:
135+
if (!set) {
136+
break;
137+
}
135138
if (set->op_en == false) {
136139
srv->state.onoff = set->onoff;
137140
} else {
@@ -209,6 +212,9 @@ static void example_handle_light_lgn_msg(bfl_ble_mesh_model_t *model,
209212
break;
210213
case BFL_BLE_MESH_MODEL_OP_LIGHT_LIGHTNESS_SET:
211214
case BFL_BLE_MESH_MODEL_OP_LIGHT_LIGHTNESS_SET_UNACK:
215+
if (!set) {
216+
break;
217+
}
212218
if (set->op_en == false) {
213219
srv->state->lightness_actual = set->lightness;
214220
} else {
@@ -243,14 +249,14 @@ static void example_ble_mesh_lighting_server_cb(bfl_ble_mesh_lighting_server_cb_
243249
}
244250
else if (param->ctx.recv_op == BFL_BLE_MESH_MODEL_OP_LIGHT_CTL_SET ||
245251
param->ctx.recv_op == BFL_BLE_MESH_MODEL_OP_LIGHT_CTL_SET_UNACK) {
246-
printf("Light ctl ln[%x]tp[%x]uv[%x]\n",
252+
printf("Light ctl ln[%x]tp[%x]uv[%x]\n",
247253
param->value.state_change.ctl_set.lightness,
248254
param->value.state_change.ctl_set.temperature,
249255
param->value.state_change.ctl_set.delta_uv);
250256
}
251257
else if (param->ctx.recv_op == BFL_BLE_MESH_MODEL_OP_LIGHT_HSL_SET ||
252258
param->ctx.recv_op == BFL_BLE_MESH_MODEL_OP_LIGHT_HSL_SET_UNACK) {
253-
printf("Light hsl l[%x]h[%x]s[%x]\n",
259+
printf("Light hsl l[%x]h[%x]s[%x]\n",
254260
param->value.state_change.hsl_set.lightness,
255261
param->value.state_change.hsl_set.hue,
256262
param->value.state_change.hsl_set.saturation);
@@ -265,15 +271,15 @@ static void example_ble_mesh_lighting_server_cb(bfl_ble_mesh_lighting_server_cb_
265271
}
266272
else if (param->ctx.recv_op == BFL_BLE_MESH_MODEL_OP_LIGHT_CTL_GET) {
267273
bfl_ble_mesh_light_ctl_srv_t *srv = param->model->user_data;
268-
printf("Light ctl ln[%x]ln_t[%x] tp[%x]tp_t[%x] uv[%x]uv_t[%x]\n",
274+
printf("Light ctl ln[%x]ln_t[%x] tp[%x]tp_t[%x] uv[%x]uv_t[%x]\n",
269275
srv->state->lightness, srv->state->target_lightness,
270276
srv->state->temperature, srv->state->target_temperature,
271277
srv->state->delta_uv, srv->state->target_delta_uv);
272278
//example_handle_gen_onoff_msg(param->model, &param->ctx, NULL);
273279
}
274280
else if (param->ctx.recv_op == BFL_BLE_MESH_MODEL_OP_LIGHT_HSL_GET) {
275281
bfl_ble_mesh_light_hsl_srv_t *srv = param->model->user_data;
276-
printf("Light ctl l[%x]l_t[%x] h[%x]h_t[%x] s[%x]s_t[%x]\n",
282+
printf("Light ctl l[%x]l_t[%x] h[%x]h_t[%x] s[%x]s_t[%x]\n",
277283
srv->state->lightness, srv->state->target_lightness,
278284
srv->state->hue, srv->state->target_hue,
279285
srv->state->saturation, srv->state->target_saturation);
@@ -293,7 +299,7 @@ static void example_ble_mesh_lighting_server_cb(bfl_ble_mesh_lighting_server_cb_
293299
}
294300
else if (param->ctx.recv_op == BFL_BLE_MESH_MODEL_OP_LIGHT_CTL_SET ||
295301
param->ctx.recv_op == BFL_BLE_MESH_MODEL_OP_LIGHT_CTL_SET_UNACK) {
296-
printf("Light ctl ln[%x] tp[%d] uv[%x] tid[%x]\n",
302+
printf("Light ctl ln[%x] tp[%d] uv[%x] tid[%x]\n",
297303
param->value.set.ctl.lightness,
298304
param->value.set.ctl.temperature,
299305
param->value.set.ctl.delta_uv,
@@ -306,7 +312,7 @@ static void example_ble_mesh_lighting_server_cb(bfl_ble_mesh_lighting_server_cb_
306312
}
307313
else if (param->ctx.recv_op == BFL_BLE_MESH_MODEL_OP_LIGHT_HSL_SET ||
308314
param->ctx.recv_op == BFL_BLE_MESH_MODEL_OP_LIGHT_HSL_SET_UNACK) {
309-
printf("Light hsl l[%x] h[%d] s[%x] tid[%x]\n",
315+
printf("Light hsl l[%x] h[%d] s[%x] tid[%x]\n",
310316
param->value.set.hsl.lightness,
311317
param->value.set.hsl.hue,
312318
param->value.set.hsl.saturation,
@@ -330,7 +336,7 @@ static void example_ble_mesh_lighting_server_cb(bfl_ble_mesh_lighting_server_cb_
330336
#ifndef CONFIG_BT_TL
331337
void bt_enable_cb(int err)
332338
{
333-
if (!err) {
339+
if (!err) {
334340
ble_cli_register();
335341
#if defined(CONFIG_BT_STACK_PTS)
336342
pts_cli_register();
@@ -340,7 +346,7 @@ void bt_enable_cb(int err)
340346
blemesh_cli_register();
341347
#if defined(CONFIG_BT_MESH_MODEL)
342348
#if defined(CONFIG_BT_MESH_MODEL_GEN_SRV)
343-
bl_gpio_enable_output(LED_PIN, LED_PIN_PULLUP, LED_PIN_PULDONW);
349+
bl_gpio_enable_output(LED_PIN, LED_PIN_PULLUP, LED_PIN_PULDONW);
344350
bfl_ble_mesh_register_generic_server_callback(example_ble_mesh_generic_server_cb);
345351
#endif
346352
#if defined(CONFIG_BT_MESH_MODEL_LIGHT_SRV)

0 commit comments

Comments
 (0)