Skip to content

add-tikv-config: add max-days and max-backups #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 4, 2025
Merged

add-tikv-config: add max-days and max-backups #2777

merged 9 commits into from
Jun 4, 2025

Conversation

yiduoyunQ
Copy link
Contributor

@yiduoyunQ yiduoyunQ commented Jun 3, 2025 •
edited
Loading

First-time contributors' checklist

What is changed, added, or deleted? (Required)

add tikv config, guide customer configure max-days and max-backups

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v2.0 (TiDB Operator 2.0 versions)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):
    TCID-11636

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2025
@hfxsd hfxsd self-assigned this Jun 3, 2025
@hfxsd hfxsd added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jun 3, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 3, 2025
@hfxsd hfxsd added needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. labels Jun 3, 2025
@hfxsd hfxsd self-requested a review June 3, 2025 10:05
hfxsd
hfxsd reviewed Jun 3, 2025
View reviewed changes
hfxsd
hfxsd reviewed Jun 3, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 3, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-03 14:59:35.876584051 +0000 UTC m=+367462.078929317: ☑️ agreed by hfxsd.

@hfxsd hfxsd changed the title add-tikv-config add-tikv-config: add max-days and max-backups Jun 3, 2025
@hfxsd hfxsd requested a review from lilin90 June 4, 2025 01:37
csuzhangxc
csuzhangxc reviewed Jun 4, 2025
View reviewed changes
hfxsd
hfxsd reviewed Jun 4, 2025
View reviewed changes
hfxsd
hfxsd reviewed Jun 4, 2025
View reviewed changes
hfxsd
hfxsd reviewed Jun 4, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 4, 2025

@hfxsd: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added the lgtm label Jun 4, 2025
@hfxsd
Copy link
Collaborator

hfxsd commented Jun 4, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 4, 2025
@ti-chi-bot ti-chi-bot bot merged commit c0cb195 into pingcap:master Jun 4, 2025
14 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs-tidb-operator that referenced this pull request Jun 4, 2025
@yiduoyunQ @ti-chi-bot
This is an automated cherry-pick of pingcap#2777
9501241 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.3: #2778.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 4, 2025
Closed
7 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.4: #2779.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/docs-tidb-operator that referenced this pull request Jun 4, 2025
@yiduoyunQ @ti-chi-bot
This is an automated cherry-pick of pingcap#2777
00f64de 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 4, 2025
Merged
7 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2780.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 4, 2025
Merged
7 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.6: #2781.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 4, 2025
Merged
7 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 4, 2025
@ti-chi-bot
add-tikv-config: add max-days and max-backups (#2777) (#2780)
b34910f
ti-chi-bot bot pushed a commit that referenced this pull request Jun 4, 2025
@ti-chi-bot
add-tikv-config: add max-days and max-backups (#2777) (#2781)
9646c01
ti-chi-bot bot pushed a commit that referenced this pull request Jun 4, 2025
@ti-chi-bot
add-tikv-config: add max-days and max-backups (#2777) (#2779)
8bf0d1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@hfxsd hfxsd hfxsd approved these changes

@lilin90 lilin90 Awaiting requested review from lilin90

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-1.3 Should cherry pick this PR to release-1.3 branch. needs-cherry-pick-release-1.4 Should cherry pick this PR to release-1.4 branch. needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiduoyunQ @hfxsd @ti-chi-bot @csuzhangxc