TiManager: fix refresh did not work (#6152)

Author: fgksgf

pkg/timanager/apis/pd/v1/types.go

@@ -86,7 +86,7 @@ type StoreState string
 const (
 	StoreStateUp        StoreState = "Up"
 	StoreStateOffline   StoreState = "Offline"
-	StoreStateTombstore StoreState = "Tombstone"
+	StoreStateTombstone StoreState = "Tombstone"
 )
 
 type NodeState string

pkg/timanager/informer.go

@@ -151,17 +151,18 @@ func (f *factory[UnderlayClient]) InformerFor(obj runtime.Object) cache.SharedIn
 		return informer
 	}
 
-	poller, ok := f.pollers[informerType]
+	p, ok := f.pollers[informerType]
 	if !ok {
-		newPollerFunc, ok := f.newPollerFuncMap[informerType]
-		if !ok {
+		newPollerFunc, ok2 := f.newPollerFuncMap[informerType]
+		if !ok2 {
 			// TODO: fix it
 			panic("unrecognized type")
 		}
-		poller = newPollerFunc(f.name, f.logger, f.c)
+		p = newPollerFunc(f.name, f.logger, f.c)
+		f.pollers[informerType] = p
 	}
 
-	lw := NewListerWatcher[UnderlayClient](f.logger, poller)
+	lw := NewListerWatcher[UnderlayClient](f.logger, p)
 
 	informer = cache.NewSharedIndexInformer(
 		lw,
@@ -179,11 +180,12 @@ func (f *factory[UnderlayClient]) Refresh(obj runtime.Object) {
 	defer f.lock.Unlock()
 
 	informerType := reflect.TypeOf(obj)
-	poller, ok := f.pollers[informerType]
+	p, ok := f.pollers[informerType]
 	if !ok {
+		f.logger.Info("no poller for type", "type", informerType)
 		return
 	}
-	poller.Refresh()
+	p.Refresh()
 }
 
 type ListerWatcher[UnderlayClient any] interface {

pkg/timanager/pd/pd.go

@@ -109,7 +109,7 @@ func SplitPrimaryKey(key string) (ns, cluster string) {
 // If any keys are changed, client will be renewed
 // The first key is primary key to get client from manager
 func CacheKeys(pdg *v1alpha1.PDGroup) ([]string, error) {
-	keys := []string{}
+	var keys []string
 
 	keys = append(keys,
 		PrimaryKey(pdg.Namespace, pdg.Spec.Cluster.Name), // cluster name as primary key

pkg/timanager/poller.go

@@ -37,7 +37,7 @@ type Poller interface {
 	// IF Run is called multiple times, the previous one will be stopped
 	// immediately and start a new one to push event to new channel
 	Run(ctx context.Context, ch chan<- watch.Event)
-	// Poll once immediately
+	// Refresh once immediately
 	Refresh()
 }
 
@@ -59,11 +59,12 @@ func NewPoller[T any, PT Object[T], L client.ObjectList](
 	interval time.Duration,
 ) Poller {
 	return &poller[T, PT, L]{
-		name:     name,
-		interval: interval,
-		lister:   lister,
-		equality: eq,
-		logger:   logger,
+		name:      name,
+		interval:  interval,
+		lister:    lister,
+		equality:  eq,
+		logger:    logger,
+		refreshCh: make(chan struct{}, bufSize),
 	}
 }