Skip to content

Conversation

@csuzhangxc
Copy link
Member

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S label Dec 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v2@98d923a). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #5982   +/-   ##
=====================================
  Coverage      ?   20.00%           
=====================================
  Files         ?      151           
  Lines         ?    10305           
  Branches      ?        0           
=====================================
  Hits          ?     2062           
  Misses        ?     8031           
  Partials      ?      212           
Flag Coverage Δ
unittest 20.00% <ø> (?)

@csuzhangxc csuzhangxc merged commit 83f5ff4 into v2 Dec 18, 2024
5 of 11 checks passed
@csuzhangxc csuzhangxc deleted the csuzhangxc/ut-cov branch December 18, 2024 05:49
liubog2008 pushed a commit to liubog2008/tidb-operator that referenced this pull request Feb 7, 2025
liubog2008 pushed a commit to liubog2008/tidb-operator that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants