Skip to content

fix(race): fix race #6170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025
Merged

Conversation

liubog2008
Copy link
Member

  • fix ut race
  • remove unused cancel func in cache

@ti-chi-bot ti-chi-bot bot requested a review from shonge April 25, 2025 09:59
Copy link

/run-pull-e2e-kind-v2

@github-actions github-actions bot added the v2 for operator v2 label Apr 25, 2025
@ti-chi-bot ti-chi-bot bot added the size/M label Apr 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.78%. Comparing base (b618aba) to head (297d610).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6170      +/-   ##
==============================================
- Coverage       51.82%   51.78%   -0.04%     
==============================================
  Files             232      232              
  Lines           16399    16411      +12     
==============================================
+ Hits             8498     8499       +1     
- Misses           7901     7912      +11     
Flag Coverage Δ
unittest 51.78% <78.57%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fgksgf
Copy link
Member

fgksgf commented Apr 25, 2025

/run-pull-e2e-kind-v2

@ti-chi-bot ti-chi-bot bot removed the lgtm label Apr 25, 2025
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2025

@liubog2008: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link

/run-pull-e2e-kind-v2

2 similar comments
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

Signed-off-by: liubo02 <liubo02@pingcap.com>
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

2 similar comments
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

Signed-off-by: liubo02 <liubo02@pingcap.com>
Copy link

/run-pull-e2e-kind-v2

Signed-off-by: liubo02 <liubo02@pingcap.com>
Copy link

/run-pull-e2e-kind-v2

@fgksgf
Copy link
Member

fgksgf commented Apr 28, 2025

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 28, 2025
Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgksgf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-25 12:57:03.511819077 +0000 UTC m=+619567.323609450: ☑️ agreed by fgksgf.
  • 2025-04-25 12:58:19.110452827 +0000 UTC m=+619642.922243205: ✖️🔁 reset by ti-chi-bot[bot].
  • 2025-04-28 01:29:49.926985236 +0000 UTC m=+837533.738775616: ☑️ agreed by fgksgf.

@ti-chi-bot ti-chi-bot bot merged commit 5cc40de into pingcap:feature/v2 Apr 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants