Add TiCI support to TidbCluster with TiFlash integration and example #6699

3pointer · 2026-02-02T08:42:53Z

Summary

This PR adds TiCI (meta/worker) as a first‑class component in TidbCluster, wires it into the controller sync loop, integrates TiFlash with TiCI config, and provides an end‑to‑end example (including MinIO + FTS verification) for local testing.

For more details about how to run tici via tidb-operator: please refer to examples/tici/readme.md

Key Changes

API/Spec/Status
- Added TiCI spec/status, new member types, labels, defaulting, and validation.
Controller/Manager
- New TiCI member manager to create services, configmaps, and statefulsets for meta/worker.
- Integrated TiCI sync into the control loop.
TiFlash integration
- Injected TiCI config into TiFlash; reader now binds to a literal IP and advertises the pod DNS.
- Added log routing option to stdout for searchlib.
Volumes
- Added TiCI member types to volume modifier.
- Avoided PVC VolumeName lookups when unset.
Examples
- New examples/tici/ with tici-tc.yaml and README (MinIO + FTS verification flow).

##Testing

Not run in CI.
Manual verification flow documented in examples/tici/README.md.

Notes / Operational Considerations

TiFlash TiCI reader requires a literal bind address; hostname-only addresses cause startup failures.
On kind/podman, pod PID limits must be removed (TasksMax/infinity) to avoid newosproc.
If reusing old TiFlash PVs, PD may reject duplicated store addresses; wipe PVC or delete the store.

Follow‑ups

Consider formalizing TiCDC changefeed creation for TiCI if desired.
Add unit tests for TiCI manager and config rendering.

ti-chi-bot · 2026-02-02T08:42:56Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

codecov-commenter · 2026-02-02T08:53:36Z

Codecov Report

❌ Patch coverage is 5.76471% with 801 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-1.x@9ab6710). Learn more about missing BASE report.

Additional details and impacted files

@@              Coverage Diff               @@
##             release-1.x    #6699   +/-   ##
==============================================
  Coverage               ?   56.42%           
==============================================
  Files                  ?      266           
  Lines                  ?    39210           
  Branches               ?        0           
==============================================
  Hits                   ?    22124           
  Misses                 ?    15002           
  Partials               ?     2084

Flag	Coverage Δ
unittest	`56.42% <5.76%> (?)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

liubog2008 · 2026-02-02T09:52:05Z

please submit pr to release-1.x

tici/tici/config/tiflash.toml.in

tici/tici/config/meta.toml.in

JaySon-Huang

lgtm

ti-chi-bot · 2026-02-09T06:11:33Z

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2026-02-09T06:11:36Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JaySon-Huang
Once this PR has been reviewed and has the lgtm label, please assign aylei for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

csuzhangxc · 2026-02-12T07:38:24Z

pkg/manager/member/tiflash_util.go

 		common.SetIfNil("flash.tidb_status_addr", tidbStatusAddr)
 		if !mountCMInTiflashContainer {
-			common.SetIfNil("flash.service_addr", fmt.Sprintf("%s:%d", listenHost, v1alpha1.DefaultTiFlashFlashPort))
+			common.SetIfNil("flash.service_addr", fmt.Sprintf("%s-POD_NUM.%s.%s.svc%s:%d",


This may cause existing TiFlash pods to be recreated after upgrading the TiDB Operator.

Thanks for pointing this out. I changed flash.service_addr in getTiFlashConfigV2 to be conditional: for non-TiCI clusters it keeps the previous value (listenHost:3930, e.g. 0.0.0.0:3930) to avoid unnecessary TiFlash pod recreation on operator upgrade; when TiCI is enabled (spec.tici.s3 configured) it uses the new headless service address.

3pointer · 2026-02-12T07:40:46Z

examples/tici/tici-tc-gcs-wi.yaml

+      region: us-east-1
+      accessKey: ""
+      secretKey: ""
+      bucket: tici_test


"_" is invalid in gcs bucket name

Fixed. I changed the GCS bucket example from tici_test to tici-test and updated the corresponding sinkURI to match. I also aligned the related docs/examples to use the same valid bucket name consistently.

ti-chi-bot · 2026-02-12T11:09:32Z

@3pointer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-e2e-kind-br	`f5fe44e`	link	false	`/test pull-e2e-kind-br`
pull-e2e-kind-scale-simultaneously	`f5fe44e`	link	false	`/test pull-e2e-kind-scale-simultaneously`
pull-e2e-kind-serial	`f5fe44e`	link	false	`/test pull-e2e-kind-serial`
pull-e2e-kind-across-kubernetes	`f5fe44e`	link	false	`/test pull-e2e-kind-across-kubernetes`
pull-e2e-kind-tngm	`f5fe44e`	link	false	`/test pull-e2e-kind-tngm`
pull-e2e-kind-basic	`f5fe44e`	link	false	`/test pull-e2e-kind-basic`
pull-e2e-kind-tidbcluster	`f5fe44e`	link	false	`/test pull-e2e-kind-tidbcluster`
pull-e2e-kind-dmcluster	`f5fe44e`	link	false	`/test pull-e2e-kind-dmcluster`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot bot added the do-not-merge/work-in-progress label Feb 2, 2026

ti-chi-bot bot requested a review from howardlau1999 February 2, 2026 08:42

ti-chi-bot bot added the size/XXL label Feb 2, 2026

liubog2008 changed the base branch from release-1.6 to release-1.x February 2, 2026 09:52

3pointer force-pushed the support_tici branch from 7646038 to b143dc5 Compare February 2, 2026 10:43

3pointer added 17 commits February 2, 2026 18:44

tici: support tici in operator v1

91ec686

update

505328a

add tici.yaml

fe35ad3

Fix tici

e878a42

second comit

44306e9

fix tici.yaml

be4c998

fix yaml

8b8b8e1

fix tici start command

24f6034

fix exec

1e1cf59

fix order

7059e7c

update

7a53e6d

udpate

aa98d6e

udpate

d2e1249

update

86b64e9

fix remove

db4e6ae

fix tiflash config

65f57bb

update readme

6513fa7

3pointer force-pushed the support_tici branch from b143dc5 to 6513fa7 Compare February 2, 2026 10:45

3pointer added 4 commits February 2, 2026 18:47

fix crd

22f684b

fix tiflash config

ac383e8

fix tiflash addr

2565365

fix scale out issue

63d87ef

format

fe26245

JaySon-Huang reviewed Feb 5, 2026

View reviewed changes

tici/tici/config/tiflash.toml.in Outdated Show resolved Hide resolved

tici/tici/config/tiflash.toml.in Outdated Show resolved Hide resolved

tici/tici/config/meta.toml.in Outdated Show resolved Hide resolved

3pointer added 3 commits February 5, 2026 15:58

fix case

96e448d

address comment

8232c2f

fix verify header

2c9ad6f

JaySon-Huang approved these changes Feb 9, 2026

View reviewed changes

3pointer added 8 commits February 10, 2026 14:41

fix ci

930c4ec

fix ci

9b3c901

tici: add gcs template && prepare for monitor

84481d2

fix changefeed race

19f08e1

fix creds

fdfc9f6

tci: support gcs web-identity

fc5d44d

fix ci

7b2d257

remove useless code

6a416b0

3pointer marked this pull request as ready for review February 11, 2026 08:35

ti-chi-bot bot removed the do-not-merge/work-in-progress label Feb 11, 2026

ti-chi-bot bot requested a review from shonge February 11, 2026 08:35

3pointer added 2 commits February 12, 2026 05:26

Merge branch 'release-1.x' into support_tici

204f92a

update document

362b4b3

csuzhangxc reviewed Feb 12, 2026

View reviewed changes

3pointer commented Feb 12, 2026

View reviewed changes

3pointer added 6 commits February 12, 2026 17:24

address comment

789bdee

fix

6426cbd

fmt

81c2224

fmt

0291caa

fmt

a3473c6

fmt

f5fe44e

Add TiCI support to TidbCluster with TiFlash integration and example #6699

Are you sure you want to change the base?

Add TiCI support to TidbCluster with TiFlash integration and example #6699

Uh oh!

Conversation

3pointer commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Changes

Notes / Operational Considerations

Follow‑ups

Uh oh!

ti-chi-bot bot commented Feb 2, 2026

Uh oh!

codecov-commenter commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

liubog2008 commented Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JaySon-Huang left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Feb 9, 2026

Uh oh!

ti-chi-bot bot commented Feb 9, 2026

Uh oh!

csuzhangxc Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

3pointer Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

3pointer Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

3pointer Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

3pointer commented Feb 2, 2026 •

edited

Loading

codecov-commenter commented Feb 2, 2026 •

edited

Loading

3pointer Feb 12, 2026 •

edited

Loading