Skip to content

consumer(ticdc): adjust consumer log level to tolerate duplicate watermark #12319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −5
Draft

consumer(ticdc): adjust consumer log level to tolerate duplicate watermark #12319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions cmd/kafka-consumer/writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,12 @@ func (p *partitionProgress) updateWatermark(newWatermark uint64, offset kafka.Of
zap.Uint64("watermark", newWatermark))
return
}
readOldOffset := true
if offset > p.watermarkOffset {
log.Panic("partition resolved ts fallback",
zap.Int32("partition", p.partition),
zap.Uint64("newWatermark", newWatermark), zap.Any("offset", offset),
zap.Uint64("watermark", watermark), zap.Any("watermarkOffset", p.watermarkOffset))
readOldOffset = false
}
log.Warn("partition resolved ts fall back, ignore it, since consumer read old offset message",
log.Warn("partition resolved ts fall back, ignore it",
zap.Bool("readOldOffset", readOldOffset),
zap.Int32("partition", p.partition),
zap.Uint64("newWatermark", newWatermark), zap.Any("offset", offset),
zap.Uint64("watermark", watermark), zap.Any("watermarkOffset", p.watermarkOffset))
Expand Down