PVS Studio with windows_amd64

[Laxilef]

Hi all,

Related: platformio/platformio-core#5194
Since version 7.18.59866, the package platformio/tool-pvs-studio is not compatible with windows_amd64:

UnknownPackageError: Could not find the package with 'platformio/tool-pvs-studio @ ^7.18.59866' requirements for your system 'windows_amd64'

And version 7.18.59865 does not work with the latest version of pio:

Checking s3_mini > pvs-studio (platform: https://github.com/pioarduino/platform-espressif32/releases/download/54.03.20/platform-espressif32.zip; board: lolin_s3_mini; framework: arduino)
---------------------------------------------------------------------------------------------------------------
In file included from D:/Projects/pvstest/.pio/packages/toolchain-riscv32-esp/picolibc/include/machine/_default_types.h:8,
                 from D:/Projects/pvstest/.pio/packages/toolchain-riscv32-esp/picolibc/include/stdint.h:12,  
                 from D:/Projects/pvstest/.pio/packages/toolchain-riscv32-esp/lib/gcc/riscv32-esp-elf/14.2.0/include/stdint.h:9,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:24,
                 from D:\Projects\pvstest\src\main.cpp:4:
D:/Projects/pvstest/.pio/packages/toolchain-riscv32-esp/picolibc/include/sys/features.h:590:9: warning: "_POSIX_READER_WRITER_LOCKS" redefined
  590 | #define _POSIX_READER_WRITER_LOCKS              200112L
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
<command-line>: note: this is the location of the previous definition
In file included from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:194:
D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32/cores/esp32/WCharacter.h:24:9: warning: "isascii" redefined
   24 | #define isascii(__c) ((unsigned)(__c) <= 0177)
      |         ^~~~~~~
In file included from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32/cores/esp32/WCharacter.h:23:
D:/Projects/pvstest/.pio/packages/toolchain-riscv32-esp/picolibc/include/ctype.h:99:9: note: this is the location of the previous definition
   99 | #define isascii(__c)    ((unsigned)(__c)<=0177)
      |         ^~~~~~~
D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32/cores/esp32/WCharacter.h:25:9: warning: "toascii" redefined
   25 | #define toascii(__c) ((__c) & 0177)
      |         ^~~~~~~
D:/Projects/pvstest/.pio/packages/toolchain-riscv32-esp/picolibc/include/ctype.h:100:9: note: this is the location of the previous definition
  100 | #define toascii(__c)    ((__c)&0177)
      |         ^~~~~~~
In file included from D:/Projects/pvstest/.pio/packages/toolchain-riscv32-esp/picolibc/include/errno.h:42,   
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/newlib/platform_include/errno.h:10,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/lwip/port/esp32xx/include/arch/cc.h:12,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/lwip/lwip/src/include/lwip/arch.h:48,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/lwip/lwip/src/include/lwip/debug.h:40,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/lwip/lwip/src/include/lwip/opt.h:52,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/lwip/lwip/src/include/lwip/ip_addr.h:40,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32/cores/esp32/IPAddress.h:25,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:199:
D:/Projects/pvstest/.pio/packages/toolchain-riscv32-esp/picolibc/include/sys/errno.h:67:9: warning: "_REENT_ERRNO" redefined
   67 | #define _REENT_ERRNO(r) (errno)
      |         ^~~~~~~~~~~~
In file included from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/newlib/platform_include/sys/reent.h:13,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/xtensa/include/xtensa_config.h:140,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/freertos/config/xtensa/include/freertos/FreeRTOSConfig_arch.h:14,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/freertos/config/include/freertos/FreeRTOSConfig.h:62,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/freertos/FreeRTOS-Kernel/include/freertos/FreeRTOS.h:63,
                 from D:/Projects/pvstest/.pio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:33:
D:/Projects/pvstest/.pio/packages/toolchain-riscv32-esp/riscv32-esp-elf/include/sys/reent.h:818:9: note: this is the location of the previous definition
  818 | #define _REENT_ERRNO(_ptr) (_tls_errno)
      |         ^~~~~~~~~~~~

Error: pvs-studio failed to perform check! Please examine tool output in verbose mode.
========================================= [FAILED] Took 7.71 seconds ========================================= 

Environment    Tool        Status    Duration
-------------  ----------  --------  ------------
s3_mini        pvs-studio  FAILED    00:00:07.705
==================================== 1 failed, 0 succeeded in 00:00:07.705 ====================================

Visual Studio Code: 1.101.2
Electron: 35.5.1
ElectronBuildId: 11727614
Chromium: 134.0.6998.205
Node.js: 22.15.1
V8: 13.4.114.21-electron.0
ОС: Windows_NT x64 10.0.22631
PlatformIO Core: 6.1.18
PlatformIO Home: 3.4.4
Arduino Release v3.2.0 based on ESP-IDF v5.4.1

Can this be fixed?

[Jason2866]

I will have a look, honestly will take a while since i have no PC where i can run Windows x86.

[Laxilef]

Why x86? I'm using x64 :)
However, in VS Code I used PlatformIO IDE extension with platform = https://github.com/pioarduino/platform-espressif32/releases/download/54.03.20/platform-espressif32.zip, not pioarduino IDE. I will test with pioarduino IDE now and give feedback.

---

Upd.
So, installed pioarduino IDE instead of PlatformIO IDE and deleted the .pio folder. If I add to platformio.ini:

check_tool = pvs-studio
check_flags =
  pvs-studio:
    --analysis-mode=4
    --exclude-path=./.pio/libdeps

Then when I run Check I see in the console:

Checking s3_mini > pvs-studio (platform: https://github.com/pioarduino/platform-espressif32/releases/download/54.03.20/platform-espressif32.zip; board: lolin_s3_mini; framework: arduino)
---------------------------------------------------------------------------------------------------------------
UnknownPackageError: Could not find the package with 'platformio/tool-pvs-studio @ ^7.18.59866' requirements for your system 'windows_amd64'

If I use the previous version:

platform_packages = platformio/tool-pvs-studio@7.18.59865
check_tool = pvs-studio
check_flags =
  pvs-studio:
    --analysis-mode=4
    --exclude-path=./.pio/libdeps

Then when I run Check I see in the console:

Checking s3_mini > pvs-studio (platform: https://github.com/pioarduino/platform-espressif32/releases/download/54.03.20/platform-espressif32.zip; board: lolin_s3_mini; framework: arduino)
---------------------------------------------------------------------------------------------------------------
In file included from D:/Projects/otgateway/.pio/packages/toolchain-riscv32-esp/picolibc/include/machine/_default_types.h:8,
                 from D:/Projects/otgateway/.pio/packages/toolchain-riscv32-esp/picolibc/include/stdint.h:12,  
                 from D:/Projects/otgateway/.pio/packages/toolchain-riscv32-esp/lib/gcc/riscv32-esp-elf/14.2.0/include/stdint.h:9,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:24,
                 from D:\Projects\otgateway\src\main.cpp:4:
D:/Projects/otgateway/.pio/packages/toolchain-riscv32-esp/picolibc/include/sys/features.h:590:9: warning: "_POSIX_READER_WRITER_LOCKS" redefined
  590 | #define _POSIX_READER_WRITER_LOCKS              200112L
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
<command-line>: note: this is the location of the previous definition
In file included from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:194:
D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32/cores/esp32/WCharacter.h:24:9: warning: "isascii" redefined
   24 | #define isascii(__c) ((unsigned)(__c) <= 0177)
      |         ^~~~~~~
In file included from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32/cores/esp32/WCharacter.h:23:
D:/Projects/otgateway/.pio/packages/toolchain-riscv32-esp/picolibc/include/ctype.h:99:9: note: this is the location of the previous definition
   99 | #define isascii(__c)    ((unsigned)(__c)<=0177)
      |         ^~~~~~~
D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32/cores/esp32/WCharacter.h:25:9: warning: "toascii" redefined
   25 | #define toascii(__c) ((__c) & 0177)
      |         ^~~~~~~
D:/Projects/otgateway/.pio/packages/toolchain-riscv32-esp/picolibc/include/ctype.h:100:9: note: this is the location of the previous definition
  100 | #define toascii(__c)    ((__c)&0177)
      |         ^~~~~~~
In file included from D:/Projects/otgateway/.pio/packages/toolchain-riscv32-esp/picolibc/include/errno.h:42,   
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/newlib/platform_include/errno.h:10,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/lwip/port/esp32xx/include/arch/cc.h:12,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/lwip/lwip/src/include/lwip/arch.h:48,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/lwip/lwip/src/include/lwip/debug.h:40,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/lwip/lwip/src/include/lwip/opt.h:52,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/lwip/lwip/src/include/lwip/ip_addr.h:40,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32/cores/esp32/IPAddress.h:25,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:199:
D:/Projects/otgateway/.pio/packages/toolchain-riscv32-esp/picolibc/include/sys/errno.h:67:9: warning: "_REENT_ERRNO" redefined
   67 | #define _REENT_ERRNO(r) (errno)
      |         ^~~~~~~~~~~~
In file included from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/newlib/platform_include/sys/reent.h:13,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/xtensa/include/xtensa_config.h:140,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/freertos/config/xtensa/include/freertos/FreeRTOSConfig_arch.h:14,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/freertos/config/include/freertos/FreeRTOSConfig.h:62,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32-libs/esp32s3/include/freertos/FreeRTOS-Kernel/include/freertos/FreeRTOS.h:63,
                 from D:/Projects/otgateway/.pio/packages/framework-arduinoespressif32/cores/esp32/Arduino.h:33:
D:/Projects/otgateway/.pio/packages/toolchain-riscv32-esp/riscv32-esp-elf/include/sys/reent.h:818:9: note: this is the location of the previous definition
  818 | #define _REENT_ERRNO(_ptr) (_tls_errno)
      |         ^~~~~~~~~~~~

Error: pvs-studio failed to perform check! Please examine tool output in verbose mode.
========================================= [FAILED] Took 5.43 seconds ========================================= 

Environment    Tool        Status    Duration
-------------  ----------  --------  ------------
s3_mini        pvs-studio  FAILED    00:00:05.427
==================================== 1 failed, 0 succeeded in 00:00:05.427 ====================================

The same errors occur when using both extensions.

[Jason2866]

The issue is:

UnknownPackageError: Could not find the package with 'platformio/tool-pvs-studio @ ^7.18.59866' requirements for your system 'windows_amd64'

the package i made for PVS-Tool is wrong/defect. Btw. you can not load this package via
platform_packages = platformio/tool-pvs-studio@7.18.59865 since pioarduino does not use Platformio registry for the used packages. A direct link has to be used like this

tool-pvs-studio @ https://github.com/pioarduino/pvs-studio-free/releases/download/7.18/tool-pvs-studio-windows-7.18.59865.tar.gz

[Jason2866]

I updated the Windows PVS-Studio pioarduino package. It was wrong. BUT i never got PVS-Studio working on my Mac. Tried original Platformio too and it always ends in the same error:

Error: pvs-studio failed to perform check! Please examine tool output in verbose mode.

with the Platformio espressif32 platform or when using pioarduino. Since i never used PVS-Studio and i dont have a license i cant help any further.

[TD-er]

PVS Studio was also giving issues when used on Windows when using WSL.
I only got it to work using PlatformIO with everything building on Windows.
Which is slowwwwww...... (> 45 mins for a full analysis of my ESPEasy project)

I have had contact with the people from PVS Studio about this and they helped me to run it via command-line which was much-much faster on WSL, but sadly the output was completely unfiltered so very hard to use.

N.B. you can get a free license from them for use with OpenSource software.
Has to be renewed yearly and part of their agreement to give out a free license is that you make a mention of PVS Studio whenever you fixed some issues reported by their tool.

Have to say I am still quite impressed by what it can find.

[Laxilef]

N.B. you can get a free license from them for use with OpenSource software.

Yes, it still is. I recently got a free license for my project :)

the package i made for PVS-Tool is wrong/defect. Btw. you can not load this package via
platform_packages = platformio/tool-pvs-studio@7.18.59865 since pioarduino does not use Platformio registry for the used packages. A direct link has to be used like this

Yes, I read about it in the first issue, but for some reason the package was downloaded and I didn't get any errors in the console indicating that the package was not found.

I updated the Windows PVS-Studio pioarduino package.

Tested with:

platform_packages = tool-pvs-studio @ https://github.com/pioarduino/pvs-studio-free/releases/download/7.36/PVS-Studio-7.36.91321.455-windows-x86_64.zip
check_tool = pvs-studio
check_flags =
  pvs-studio:
    --analysis-mode=4
    --exclude-path=./.pio/libdeps

Result:

Checking s3_mini > pvs-studio (platform: https://github.com/pioarduino/platform-espressif32/releases/download/54.03.20/platform-espressif32.zip; board: lolin_s3_mini; framework: arduino)
---------------------------------------------------------------------------------------------------------------
TypeError: Traceback (most recent call last):
  File "C:\Users\Yurii\.platformio\penv\Lib\site-packages\platformio\__main__.py", line 103, in main
    cli()  # pylint: disable=no-value-for-parameter
    ~~~^^
  File "C:\Users\Yurii\.platformio\penv\Lib\site-packages\click\core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "C:\Users\Yurii\.platformio\penv\Lib\site-packages\click\core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "C:\Users\Yurii\.platformio\penv\Lib\site-packages\platformio\cli.py", line 85, in invoke
    return super().invoke(ctx)
           ~~~~~~~~~~~~~~^^^^^
  File "C:\Users\Yurii\.platformio\penv\Lib\site-packages\click\core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "C:\Users\Yurii\.platformio\penv\Lib\site-packages\click\core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Yurii\.platformio\penv\Lib\site-packages\click\core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "C:\Users\Yurii\.platformio\penv\Lib\site-packages\platformio\check\cli.py", line 151, in cli
    ct = CheckToolFactory.new(
        tool, os.getcwd(), config, envname, tool_options
    )
  File "C:\Users\Yurii\.platformio\penv\Lib\site-packages\platformio\check\tools\__init__.py", line 33, in new 
    return cls(project_dir, config, envname, options)
  File "C:\Users\Yurii\.platformio\penv\Lib\site-packages\platformio\check\tools\pvsstudio.py", line 36, in __init__
    self.tool_path = os.path.join(
                     ~~~~~~~~~~~~^
        self.get_tool_dir("tool-pvs-studio"),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        "x64" if IS_WINDOWS else "bin",
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        "pvs-studio",
        ^^^^^^^^^^^^^
    )
    ^
  File "<frozen ntpath>", line 100, in join
TypeError: expected str, bytes or os.PathLike object, not NoneType

============================================================

An unexpected error occurred. Further steps:

* Verify that you have the latest version of PlatformIO using
  `python -m pip install -U platformio` command

* Try to find answer in FAQ Troubleshooting section
  https://docs.platformio.org/page/faq/index.html

* Report this problem to the developers
  https://github.com/platformio/platformio-core/issues

============================================================

Maybe I'm doing something wrong? Thanks.

[Jason2866]

There is no platform_packages needed. Either it works now with the updated package or not.
As said before, can't get any PVS-TOOL working so i have no idea whats wrong (or not).

[Laxilef]

Well, without platform_packages I see an error:

Tool Manager: Installing platformio/tool-pvs-studio @ ^7.18.59866
UnknownPackageError: Could not find the package with 'platformio/tool-pvs-studio @ ^7.18.59866' requirements for your system 'windows_amd64'

[Jason2866]

Yes, since actual tool is 7.36.91321 with pioarduino. pioarduino does not support Platformio registry anymore. This is not a valid entry platformio/tool-pvs-studio @ ^7.18.59866
Available PVS-Tool versions are here https://github.com/pioarduino/pvs-studio-free/releases

BUT every tool in pioarduino is choosen for a reason, changes can end in troubles.
The drop for Platformio Registry support is intended and not a bug.

The error you see, you have an outdated platform. Delete folder .platformio/platforms