Skip to content

add ebiten game #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

add ebiten game #317

wants to merge 18 commits into from

Conversation

ValorZard
Copy link

Description

Add Ebiten Game project from https://github.com/ValorZard/gopher-combat

Note: There are two main issues with this project that aren't dealbreaking, but I'd like to see fixed at some point

  1. It can only support two players (needs refactoring)
  2. It requires a third party library for UI (ebitenui) I'm not too happy with this, since for forward compatibility sake it would be better if we ONLY depended on ebiten itself. However, I'm not sure if it worth it to add the complexity of our own UI to this. If we do, it should be in a seperate ui.go file

@ValorZard
Copy link
Author

ValorZard commented Apr 12, 2025

Actually switching the UI to this would probably be smart: https://github.com/ebitengine/debugui (however its not stable yet)

@JoeTurki JoeTurki self-assigned this Apr 12, 2025
Copy link

codecov bot commented Apr 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 608 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (c85f51e) to head (84ce3af).

Files with missing lines Patch % Lines
ebiten-game/game/main.go 0.00% 325 Missing ⚠️
ebiten-game/signaling-server/main.go 0.00% 241 Missing ⚠️
ebiten-game/game/ui.go 0.00% 42 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #317     +/-   ##
========================================
  Coverage    0.00%   0.00%             
========================================
  Files          25      11     -14     
  Lines        2832     986   -1846     
========================================
+ Misses       2832     986   -1846     
Flag Coverage Δ
go ?
wasm 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ValorZard
Copy link
Author

Ah, 0.1 of debugui is already released, we can just pin to that: https://github.com/ebitengine/debugui/releases/tag/v0.1.0

@ValorZard
Copy link
Author

Okay so we removed the third party library and replaced it with debugui, so now all we're depending on is ebiten! This is great! Honestly the only issue now is the fact that its only two player (which would need to be fixed by a refactoring of how the signaling server works...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants