Skip to content

Add Ebiten game example #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add Ebiten game example #329

wants to merge 7 commits into from

Conversation

JoeTurki
Copy link
Member

Description

Add ebiten game by @ValorZard

#317

Copy link

codecov bot commented May 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 686 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (8037e4d) to head (4c8c049).

Files with missing lines Patch % Lines
ebiten-game/game/main.go 0.00% 326 Missing ⚠️
ebiten-game/signaling-server/main.go 0.00% 318 Missing ⚠️
ebiten-game/game/ui.go 0.00% 42 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #329    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files          25      28     +3     
  Lines        2861    3547   +686     
=======================================
- Misses       2861    3547   +686     
Flag Coverage Δ
go 0.00% <0.00%> (ø)
wasm 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoeTurki JoeTurki force-pushed the ValorZard-master branch from a15fa8b to 814383e Compare May 11, 2025 05:28
@ValorZard
Copy link

After this PR gets merged, I’ll probably open up a new one to do some refactors

  1. Figure out how to actually use the signaling server between different browsers on different computers (due to I think cross origin issues). Using something like ngix should fix it?
    IIRC this was something that seems easy to do, so it could be part of this PR.
  2. I want to replace the current long polling we’re doing to use server side events instead (probably using this library: https://github.com/tmaxmax/go-sse
  3. Refactor main.go in the game code to split out the host and client code into their own separate files (host.go and client.go)
  • Host and Client code is so different that it doesn’t make sense to shove it all into one function anymore
  • Would make more sense to have a Host struct and a Client Struct and have associated functions with each
  • Host struct would have an map of all the peer connections for all the clients connected to it
  1. Make it so that players can drop in and drop out of the session at any time
  • this is just a neat feature that webrtc lets us do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants