Add logs for sfu-ws #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgojin
force-pushed
the
add-logs-for-sfu-ws
branch
from
aa799f9 to
794232b
Compare
|
@cgojin sorry I have been slow on reviews :( I think this is a great change, are you still interested in merging it? |
It's okay, merge it if you have time, thank you! |
Sean-Der
force-pushed
the
add-logs-for-sfu-ws
branch
from
cec7a4b to
094b5de
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 25 25
Lines 2803 2825 +22
======================================
- Misses 2803 2825 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Add logs and use pion's logger
Sean-Der
force-pushed
the
add-logs-for-sfu-ws
branch
from
094b5de to
f5d8e00
Compare
|
Almost 4 years late, but it finally got merged. thank you @cgojin |
Sean-Der
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some logs for debugging sfu-ws