Update main.go #86
Merged
Update main.go #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jason-shen, I see the CI tests failing. Do you mind to fix them and rebase your changes on the latest master? |
If you are serializing a candidate make sure to use ToJSON Using Marshal will result in errors around `sdpMid`
Sean-Der
force-pushed
the
jason-shen-patch-1
branch
from
c9b7821 to
f64faa5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 25 25
Lines 2803 2803
======================================
Misses 2803 2803
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sean-Der
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added comment
If you are serializing a candidate make sure to use ToJSON
Using Marshal will result in errors around
sdpMidDescription
Reference issue
Fixes #...