Skip to content

[Bug]: Can access dashboard, even when not logged in #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
Amogh-Nivaskar opened this issue Oct 9, 2023 · 4 comments · May be fixed by #113, #173 or #218
Open
1 task done

[Bug]: Can access dashboard, even when not logged in #102

Amogh-Nivaskar opened this issue Oct 9, 2023 · 4 comments · May be fixed by #113, #173 or #218
Assignees
@Amogh-Nivaskar
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Hacktoberfest Accepted Issues

Comments

@Amogh-Nivaskar
Copy link
Contributor

Describe the bug

  1. Currently one can still access the dashboard even when one is not logged in, or even when the user's authentication token has expired.

To Reproduce

  1. Logout of the application if you are logged in
  2. Go to http://app.localhost:3000/dashboard
  3. You are still able to access the dashboard

Expected behavior

I think that if the user is not logged in or if their authentication token has expired, and he/she tries to access the dashboard or any of its child routes, the user should be redirected to the login page. We should protect this route. This leads to a better user experience.

Screenshots/Videos

image

Additional context

No response

Please checkmark the following checklist

  • I make sure that similar issue is not opened
@Amogh-Nivaskar Amogh-Nivaskar added the bug Something isn't working label Oct 9, 2023
@Amogh-Nivaskar
Copy link
Contributor Author

can this issue be assigned to me?

@piyushgarg-dev piyushgarg-dev added good first issue Good for newcomers hacktoberfest Hacktoberfest Accepted Issues hacktoberfest-accepted Hacktoberfest Accepted labels Oct 9, 2023
@piyushgarg-dev
Copy link
Owner

Done @Amogh-Nivaskar

@Amogh-Nivaskar Amogh-Nivaskar linked a pull request Oct 9, 2023 that will close this issue
Open
2 tasks
@hemantwasthere hemantwasthere removed the hacktoberfest-accepted Hacktoberfest Accepted label Oct 9, 2023
@Hari1122-code Hari1122-code mentioned this issue Oct 9, 2023
Closed
@Atharva1723
Copy link

@piyushgarg-dev Still the issue persist even if i have not logged in . I can access the dashboard .Please assign me this issue
image

@Nick-h4ck3r Nick-h4ck3r linked a pull request Oct 15, 2023 that will close this issue
Open
3 tasks
@avdhendra
Copy link

is this issue resolve or i can take this issue

@TusharKumawat1 TusharKumawat1 linked a pull request Oct 21, 2023 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Amogh-Nivaskar Amogh-Nivaskar

Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Hacktoberfest Accepted Issues
Projects
None yet
Milestone
No milestone
5 participants
@piyushgarg-dev @avdhendra @hemantwasthere @Atharva1723 @Amogh-Nivaskar