Create Board Definition for Waveshare ESP32-S3 with 1.28 in Display #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @deisterhold, thanks for the PR. It's highly desirable that a proper variant header file is added to this repo https://github.com/espressif/arduino-esp32 in the first place. |
Variant is based on this PR espressif/arduino-esp32#9386
|
@valeros created PR for new variant and updated in board definition. |
|
PR has been merged. |
|
Thanks for pinging, the board will be added once a new stable release of Arduino core is published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add board definition for:
https://www.waveshare.com/esp32-s3-touch-lcd-1.28.htm