Skip to content

Commit 5f43b93

Browse files
mvaligurskyMartin Valigursky
andauthored
Shader creation no longer supplies dummy shader in none is specified (#7651)
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
1 parent 4081c8d commit 5f43b93

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/platform/graphics/shader-utils.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ class ShaderUtils {
149149
ShaderUtils.precisionCode(device)}
150150
${sharedGLSL}
151151
${ShaderUtils.getShaderNameCode(name)}
152-
${options.fragmentCode || ShaderUtils.dummyFragmentCode()}`;
152+
${options.fragmentCode}`;
153153
}
154154

155155
return {
@@ -193,10 +193,6 @@ class ShaderUtils {
193193
return `#define SHADER_NAME ${name}\n`;
194194
}
195195

196-
static dummyFragmentCode() {
197-
return 'void main(void) {gl_FragColor = vec4(0.0);}';
198-
}
199-
200196
static versionCode(device) {
201197
return device.isWebGPU ? '#version 450\n' : '#version 300 es\n';
202198
}

src/platform/graphics/transform-feedback.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,8 @@ class TransformFeedback {
123123
return new Shader(graphicsDevice, ShaderUtils.createDefinition(graphicsDevice, {
124124
name,
125125
vertexCode,
126-
useTransformFeedback: true
126+
useTransformFeedback: true,
127+
fragmentCode: 'void main(void) {gl_FragColor = vec4(0.0);}'
127128
}));
128129
}
129130

0 commit comments

Comments
 (0)