-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: Update config diff check method to handle nested arrays #7579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b480d04
Linting/formatting
camdecoster 34a669e
Move diff function to helpers and update to handle nested arrays
camdecoster 364466a
Add tests for diff function
camdecoster 3b3816f
Switch object clone method to keep undefined values in clone
camdecoster 20c534f
Switch loops to improve performance
camdecoster 47be541
Fix test label
camdecoster ef102cc
Add draftlog
camdecoster 1b65938
Fix bad loop conversion
camdecoster 0da832e
Move constant to top of file; remove unused require
camdecoster 2767f07
Switch method to check for equality
camdecoster 01e698a
Update tests per method change
camdecoster 8ceebdf
Handle when collections aren't objects or object+array
camdecoster 3bc5b7e
Add more tests
camdecoster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make sense for this case to return
true?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose, but that's not how the function is supposed to be used. It would require an additional branch to the conditional check and I didn't feel like adding that. If you feel strongly about it, I'll add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah I don't feel strongly about it. My only suggestion would be to note these details in the function docstring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSDoc param specs show the args should be an array or object. Do you think more would be necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah my bad I skimmed over the jsdoc, if that conventionally means
nullis not a valid input I'm satisfied 👍