Skip to content

Commit b933482

Browse files
committed
Fix undefined multiple during migration
1 parent fe73d5b commit b933482

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

inc/toolbox.class.php

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@
2828
* -------------------------------------------------------------------------
2929
*/
3030

31-
use Glpi\Toolbox\Sanitizer;
32-
3331
class PluginFieldsToolbox
3432
{
3533
/**
@@ -141,20 +139,20 @@ public function fixFieldsNames(Migration $migration, $condition)
141139
// limit tables names to 64 chars (MySQL limit)
142140
$new_name = substr($new_name, 0, -1);
143141
}
144-
$field['name'] = $new_name;
145-
$field_obj->update(
146-
Sanitizer::dbEscapeRecursive($field),
147-
false
142+
$DB->update(
143+
PluginFieldsField::getTable(),
144+
['name' => $new_name],
145+
['id' => $field['id']]
148146
);
149147

150148
$sql_fields_to_rename = [
151-
$old_name => $field['name'],
149+
$old_name => $new_name,
152150
];
153151

154152
if ('dropdown' === $field['type']) {
155153
// Rename dropdown table
156154
$old_table = getTableForItemType(PluginFieldsDropdown::getClassname($old_name));
157-
$new_table = getTableForItemType(PluginFieldsDropdown::getClassname($field['name']));
155+
$new_table = getTableForItemType(PluginFieldsDropdown::getClassname($new_name));
158156

159157
if ($DB->tableExists($old_table)) {
160158
$migration->renameTable($old_table, $new_table);

0 commit comments

Comments
 (0)