Skip to content

Fix - Resolve SQL alias errors and undefined array keys #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 30, 2025
Merged

Fix - Resolve SQL alias errors and undefined array keys #295

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
883277b
Fix - Resolve SQL alias errors and undefined array keys
RomainLvr Sep 1, 2025
1b5083b
Remove useless fallback
RomainLvr Sep 1, 2025
df6f884
Update CHANGELOG
RomainLvr Sep 30, 2025
a240e8c
Merge branch 'main' into fix/sql-alias-and-array-keys
RomainLvr Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions inc/common.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,9 +743,9 @@ public static function dropdownExt($options = [])
public static function endGraph($options, $dashboard = false)
{
$opt = $options['opt'];
$export = $options['export'];
$datas = $options['datas'];
$unit = $options['unit'];
$export = $options['export'] ?? null;
$datas = $options['datas'] ?? [];
$unit = $options['unit'] ?? '';
$labels2 = [];
$flip_data = false;

Expand Down
8 changes: 4 additions & 4 deletions inc/helpdeskplus.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,13 @@ public function __construct($config = [])

if (isset($mr_values['groups_assign_id'])) {
$this->criteria_group_assign = [
Group_Ticket::getTable() . '.groups_id' => $mr_values['groups_assign_id'],
'gt.groups_id' => $mr_values['groups_assign_id'],
];
}

if (isset($mr_values['groups_request_id'])) {
$this->criteria_group_assign = [
Group_Ticket::getTable() . '.groups_id' => $mr_values['groups_request_id'],
$this->criteria_group_request = [
'gtr.groups_id' => $mr_values['groups_request_id'],
];
}

Expand Down Expand Up @@ -1337,7 +1337,7 @@ public function reportVstackbarRespectedSlasByGroup($config = [])
Ticket::getTable() . '.status' => array_merge(Ticket::getSolvedStatusArray(), Ticket::getClosedStatusArray()),
SLA::getTable() . '.id' => $_SESSION['mreporting_values']['slas'],
],
'GROUPBY' => ['glpi_groups_tickets.groups_id', 'respected_sla'],
'GROUPBY' => [Group_Ticket::getTable() . '.groups_id', 'respected_sla'],
];
$query['WHERE']['AND'] = $delay;

Expand Down