Small logging improvements

Author: adangel

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/cmd/ReviewCodeCmd.java

@@ -39,6 +39,7 @@
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashMap;
+import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
@@ -96,7 +97,7 @@ public class ReviewCodeCmd extends AbstractDefaultCommand {
 
     private static final Logger LOG = Logger.getLogger(ReviewCodeCmd.class);
 
-    private final List<ISchedulingRule> resources = new ArrayList<ISchedulingRule>();
+    private final List<IResource> resources = new ArrayList<IResource>();
     private IResourceDelta resourceDelta;
     private Map<IFile, Set<MarkerInfo2>> markersByFile = new HashMap<IFile, Set<MarkerInfo2>>();
     private boolean taskMarker;
@@ -277,12 +278,12 @@ public void run() {
 
             // Log performance information
             if (fileCount > 0 && ruleCount > 0) {
-                logInfo("Review code command terminated. " + ruleCount + " rules were executed against " + fileCount
+                logInfo("Review code command finished. " + ruleCount + " rules were executed against " + fileCount
                         + " files. Actual PMD duration is about " + pmdDuration + "ms, that is about "
                         + (float) pmdDuration / fileCount + " ms/file, " + (float) pmdDuration / ruleCount
                         + " ms/rule, " + (float) pmdDuration / ((long) fileCount * (long) ruleCount) + " ms/filerule");
             } else {
-                logInfo("Review code command terminated. " + ruleCount + " rules were executed against " + fileCount
+                logInfo("Review code command finished. " + ruleCount + " rules were executed against " + fileCount
                         + " files. PMD was not executed.");
             }
         }
@@ -420,10 +421,13 @@ private ISchedulingRule getSchedulingRule() {
      * @throws CommandException
      */
     private void processResources() throws CommandException {
-        final Iterator<ISchedulingRule> i = resources.iterator();
-        while (i.hasNext()) {
-            final IResource resource = (IResource) i.next();
+        Set<String> projects = new HashSet<String>();
+        for (IResource resource : resources) {
+            projects.add(resource.getProject().getName());
+        }
+        logInfo("ReviewCodeCmd started with " + resources.size() + " selected resources on projects " + projects);
 
+        for (IResource resource : resources) {
             // if resource is a project, visit only its source folders
             if (resource instanceof IProject) {
                 processProject((IProject) resource);
@@ -508,7 +512,8 @@ private void processResource(IResource resource) throws CommandException {
     private void processProject(IProject project) throws CommandException {
         try {
             setStepCount(countResourceElement(project));
-            LOG.debug("Visiting  project " + project.getName() + " : " + getStepCount());
+            logInfo("ReviewCodeCmd: visiting project " + project.getName() + ": " + getStepCount() + " resources found.");
+            LOG.debug("Visiting project " + project.getName() + " : " + getStepCount() + " resources found.");
 
             if (project.hasNature(JavaCore.NATURE_ID)) {
                 processJavaProject(project);
@@ -609,6 +614,7 @@ private void processResourceDelta() throws CommandException {
             IResource resource = resourceDelta.getResource();
             final IProject project = resource.getProject();
             final IProjectProperties properties = getProjectProperties(project);
+            logInfo("ReviewCodeCmd started on resource delta " + resource.getName() + " in project " + project.getName());
 
             RuleSet ruleSet = rulesetFromResourceDelta(); // properties.getProjectRuleSet();
 
@@ -680,7 +686,7 @@ private void applyMarkers() {
         } finally {
             timer.stop();
             int count = markersByFile.size();
-            logInfo("" + violationCount + " markers applied on " + count + " files in " + timer.getDuration() + "ms.");
+            LOG.info("" + violationCount + " markers applied on " + count + " files in " + timer.getDuration() + "ms.");
             LOG.info("End of processing marker directives. " + violationCount + " violations for " + count + " files.");
         }
     }

net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/properties/impl/ProjectPropertiesImpl.java

@@ -462,7 +462,7 @@ public ClassLoader getAuxClasspath() {
         try {
             if (project != null && project.hasNature(JavaCore.NATURE_ID)) {
                 if (auxclasspath == null) {
-                    LOG.debug("Creating new auxclaspath class loader for project " + project.getName());
+                    PMDPlugin.getDefault().logInformation("Creating new auxclasspath class loader for project " + project.getName());
                     auxclasspath = new JavaProjectClassLoader(PMD.class.getClassLoader(), project);
                 }
                 return auxclasspath;