Skip to content

Commit edadf13

Browse files
committed
Fixed memory leak during clone
1 parent a8ed0d0 commit edadf13

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

classes/ByteBufferWriter.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@ static zend_object* writer_new(zend_class_entry* ce) {
3636

3737
static zend_object* writer_clone(zend_object* object) {
3838
auto old_object = fetch_from_zend_object<byte_buffer_writer_zend_object>(object);
39-
auto new_object = fetch_from_zend_object<byte_buffer_writer_zend_object>(writer_new(object->ce));
40-
41-
zend_objects_clone_members(&new_object->std, &old_object->std);
39+
auto new_object = alloc_custom_zend_object<byte_buffer_writer_zend_object>(object->ce, &byte_buffer_writer_zend_object_handlers);
4240

4341
writer_init_properties(new_object, old_object->writer.buffer, old_object->writer.used, old_object->writer.offset);
4442

43+
zend_objects_clone_members(&new_object->std, &old_object->std);
44+
4545
return &new_object->std;
4646
}
4747

0 commit comments

Comments
 (0)