spfx project upgrade to 1.11: What is going on with @types packages?

[pschaeflein]

In the output of spfx project upgrade from 1.10 to 1.11, several @types packages in the are included in the second command, which I assume is an upgrade.

npm i -DE <snip> @types/webpack-env@1.13.1 @types/es6-promise@0.0.33 @types/react@16.8.8 @types/react-dom@16.8.3

They are also included in the third command, which is uninstall.

npm un -S @types/webpack-env @types/es6-promise @types/react @types/react-dom

While not necessarily a bug, should this be streamlined? Happy to open an issue if appropriate.

[garrytrinder]

Based on the commands you have highlighted, my hypothesis is that in v1.10 the @types were incorrectly installed as dependencies instead of devDependencies.

• npm i -DE installs the specified packages as exact versions (E) adding them to the devDependencies section (D) in package.json

• npm un -S uninstalls the packages specified and removing the packages from the dependencies section (S) in package.json

So after following the upgrade steps you should only have @types displaying in the devDependencies section.

[pschaeflein]

Excellent!! Thanks so much. Seems the issue was in front of the keyboard. ;)

[garrytrinder]

Haha, no problem, happy to help 👍🏻