Skip to content

feat: Add Travel Request Approval Management App #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: Add Travel Request Approval Management App #122

wants to merge 7 commits into from

Conversation

summitbaj
Copy link

@summitbaj summitbaj commented Jan 29, 2025 •
edited
Loading

  • New canvas app for travel approvals
  • Added solution components and assets
  • Updated documentation and metadata

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <name@example.com>

Put an x in all the items that apply ([x], without spaces), make notes next to any that haven't been addressed.

  • Bug fix?
  • [ x] New sample?
  • Related issues: fixes #X, partially #Y, mentioned in #Z
  • Needs API permissions?
  • Has other prerequisites? (E.g. requires a list, document library, etc.)

What's in this Pull Request?

✅ Added enterprise-grade travel request management solution.

Checklist

This checklist is mostly useful as a reminder of small things that can easily be forgotten – it is meant as a helpful tool rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces), make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • I have updated the README file.
  • My README has at least one static high-resolution screenshot (i.e. not a GIF)
  • My README contains complete setup instructions, including pre-requisites and permissions required

Submitter Guidance (DELETE AFTER READING)

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.

Pull requests that do not follow this template will be automatically rejected.

Please target your PR to main branch.

@summitbaj
feat: Add Travel Request Approval Management App
3bd5bc5 
- New canvas app for travel approvals
- Added solution components and assets
- Updated documentation and metadata
@github-actions GitHub Actions
Copy link

Validation failed!

File: samples/travel-request-approval/assets/sample.json

@github-actions GitHub Actions
Copy link

Validation failed!

File: samples/travel-request-approval/assets/sample.json

@github-actions GitHub Actions
Copy link

Validation failed!

File: samples/travel-request-approval/assets/sample.json

@github-actions GitHub Actions
Copy link

Validation failed!

File: samples/travel-request-approval/assets/sample.json

@Katerina-Chernevskaya
Copy link
Contributor

Hi @summitbaj ,

Thank you for your submission!
To proceed the review process could you please check the source code of the solution? When I tried to pack it I got the following error:
image

Please ensure you followed this instruction for the source code preparation.

If you have any questions - feel free to ping me.

Best regards,
Katerina Chernevskaya

@Katerina-Chernevskaya Katerina-Chernevskaya added the Needs Attention Something needs to be fixed with the PR before merging label Feb 12, 2025
@summitbaj
Copy link
Author

Hi @Katerina-Chernevskaya ,
I figured out what was going on. I have made a fix you can test now. Thanks )

@Katerina-Chernevskaya
Copy link
Contributor

Hi @summitbaj ,

Thank you for fixing the error. Now I was able to pack the solution successfully.

However, when I tried to import it, the Missing dependencies issue occurred:
image
image

Could you please resolve it? You can either include required components into your solution, or explicitly list what should be installed in the environment where your solution will be imported. You can use Prerequisite section for this.

Thank you!

Regards,
Katerina Ch.

@summitbaj
Copy link
Author

Hi @Katerina-Chernevskaya ,
I'm so sorry. I’ve completed a thorough verification of the solution, and it should now import successfully. There were some unexpected dependencies that got integrated, but I’ve resolved them. Please let me know if you encounter any issues.

@Katerina-Chernevskaya
Copy link
Contributor

Hi @summitbaj ,

Thank you fixed. Now I import the solution without issues. However, when I try to play the app and submit a request - 2 fields are disabled for me - 'Travel Cost' and 'Requested To 1':
image

Could you please check this? May be there are any prerequisites that should be done before using the app? If so, please describe them in Readme file.

Thank you!

Katerina Ch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Katerina-Chernevskaya Katerina-Chernevskaya Awaiting requested review from Katerina-Chernevskaya

Assignees
No one assigned
Labels
Needs Attention Something needs to be fixed with the PR before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@summitbaj @Katerina-Chernevskaya