Skip to content

Commit 83de949

Browse files
hugoabernierhugoabernier
authored
Merge pull request #5378 from a1mery/react-modern-birthdays-upgrade-to-v1.20
2 parents b76f9ae + 7147ffb commit 83de949

29 files changed

+21474
-57475
lines changed

‎samples/react-modern-birthdays/.eslintrc.js

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -22,42 +22,6 @@ module.exports = {
2222
'@typescript-eslint/adjacent-overload-signatures': 1,
2323
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
2424
//
25-
// CONFIGURATION: By default, these are banned: String, Boolean, Number, Object, Symbol
26-
'@typescript-eslint/ban-types': [
27-
1,
28-
{
29-
'extendDefaults': false,
30-
'types': {
31-
'String': {
32-
'message': 'Use \'string\' instead',
33-
'fixWith': 'string'
34-
},
35-
'Boolean': {
36-
'message': 'Use \'boolean\' instead',
37-
'fixWith': 'boolean'
38-
},
39-
'Number': {
40-
'message': 'Use \'number\' instead',
41-
'fixWith': 'number'
42-
},
43-
'Object': {
44-
'message': 'Use \'object\' instead, or else define a proper TypeScript type:'
45-
},
46-
'Symbol': {
47-
'message': 'Use \'symbol\' instead',
48-
'fixWith': 'symbol'
49-
},
50-
'Function': {
51-
'message': 'The \'Function\' type accepts any function-like value.\nIt provides no type safety when calling the function, which can be a common source of bugs.\nIt also accepts things like class declarations, which will throw at runtime as they will not be called with \'new\'.\nIf you are expecting the function to accept certain arguments, you should explicitly define the function shape.'
52-
}
53-
}
54-
}
55-
],
56-
// RATIONALE: Code is more readable when the type of every variable is immediately obvious.
57-
// Even if the compiler may be able to infer a type, this inference will be unavailable
58-
// to a person who is reviewing a GitHub diff. This rule makes writing code harder,
59-
// but writing code is a much less important activity than reading it.
60-
//
6125
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
6226
'@typescript-eslint/explicit-function-return-type': [
6327
1,

‎samples/react-modern-birthdays/.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
v18.18.0

‎samples/react-modern-birthdays/.yo-rc.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
"nodeVersion": "16.18.1",
66
"sdksVersions": {
77
"@microsoft/microsoft-graph-client": "3.0.2",
8-
"@microsoft/teams-js": "2.4.1"
8+
"@microsoft/teams-js": "2.24.0"
99
},
10-
"version": "1.16.1",
10+
"version": "1.20.0",
1111
"libraryName": "react-birthdays",
1212
"libraryId": "caf83914-77f3-470c-b71c-21d8820c48a9",
1313
"environment": "spo",

‎samples/react-modern-birthdays/README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ The Web Part(s) shows the upcoming birthdays in the company, the web parts reads
1414
| Every SPFx version is only compatible with specific version(s) of Node.js. In order to be able to build this sample, please ensure that the version of Node on your workstation matches one of the versions listed in this section. This sample will not work on a different version of Node.|
1515
|Refer to <https://aka.ms/spfx-matrix> for more information on SPFx compatibility. |
1616

17-
![SPFx 1.16.1](https://img.shields.io/badge/SPFx-1.16.1-green.svg)
18-
![Node.js v16 | v14](https://img.shields.io/badge/Node.js-v16%20|%20v14-green.svg)
17+
![SPFx 1.20.0](https://img.shields.io/badge/SPFx-1.20.0-green.svg)
18+
![Node.js v18](https://img.shields.io/badge/Node.js-v18-green.svg)
1919
![SharePoint Online](https://img.shields.io/badge/SharePoint-Online-yellow.svg)
2020
![Workbench Hosted: Does not work with local workbench](https://img.shields.io/badge/Workbench-Hosted-yellow.svg "Does not work with local workbench")
2121
![Compatible with Remote Containers](https://img.shields.io/badge/Remote%20Containers-Compatible-green.svg)
@@ -42,12 +42,14 @@ email | Text | true
4242
## Contributors
4343

4444
* [João Mendes](https://github.com/joaojmendes)
45+
* [Aimery Thomas](https://github.com/a1mery)
4546

4647
## Version history
4748

4849
Version|Date|Comments
4950
-------|----|--------
5051
1.0.0|January 31, 2023|Initial release
52+
1.1.0|January 19, 2025|Upgrade to SPFx v1.20.0
5153

5254
## Minimal Path to Awesome
5355

‎samples/react-modern-birthdays/assets/sample.json

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"Shows upcoming birthdays in the company, laid out in a timeline"
1111
],
1212
"creationDateTime": "2023-01-31",
13-
"updateDateTime": "2023-01-31",
13+
"updateDateTime": "2025-01-19",
1414
"products": [
1515
"SharePoint"
1616
],
@@ -21,7 +21,7 @@
2121
},
2222
{
2323
"key": "SPFX-VERSION",
24-
"value": "1.16.1"
24+
"value": "1.20.0"
2525
}
2626
],
2727
"thumbnails": [
@@ -37,6 +37,11 @@
3737
"gitHubAccount": "joaojmendes",
3838
"pictureUrl": "https://github.com/joaojmendes.png",
3939
"name": "João Mendes"
40+
},
41+
{
42+
"gitHubAccount": "a1mery",
43+
"pictureUrl": "https://github.com/a1mery.png",
44+
"name": "Aimery Thomas"
4045
}
4146
],
4247
"references": [
@@ -58,7 +63,7 @@
5863
"The Web Part shows the upcoming birthdays in the company, the web parts reads birthdays from a list located on the tenant's root site with title \"Birthdays.\""
5964
],
6065
"creationDateTime": "2023-01-31",
61-
"updateDateTime": "2023-01-31",
66+
"updateDateTime": "2025-01-19",
6267
"products": [
6368
"SharePoint"
6469
],
@@ -69,7 +74,7 @@
6974
},
7075
{
7176
"key": "SPFX-VERSION",
72-
"value": "1.16.1"
77+
"value": "1.20.0"
7378
}
7479
],
7580
"thumbnails": [
@@ -85,6 +90,11 @@
8590
"gitHubAccount": "joaojmendes",
8691
"pictureUrl": "https://github.com/joaojmendes.png",
8792
"name": "João Mendes"
93+
},
94+
{
95+
"gitHubAccount": "a1mery",
96+
"pictureUrl": "https://github.com/a1mery.png",
97+
"name": "Aimery Thomas"
8898
}
8999
],
90100
"references": [

‎samples/react-modern-birthdays/config/package-solution.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"solution": {
44
"name": "react-birthdays-client-side-solution",
55
"id": "caf83914-77f3-470c-b71c-21d8820c48a9",
6-
"version": "1.0.0.0",
6+
"version": "1.1.0.0",
77
"includeClientSideAssets": true,
88
"skipFeatureDeployment": true,
99
"isDomainIsolated": false,

‎samples/react-modern-birthdays/config/serve.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"$schema": "https://developer.microsoft.com/json-schemas/spfx-build/spfx-serve.schema.json",
33
"port": 4321,
44
"https": true,
5-
"initialPage": "https://enter-your-SharePoint-site/_layouts/workbench.aspx"
5+
"initialPage": "https://{tenantDomain}/_layouts/workbench.aspx"
66
}

0 commit comments

Comments
 (0)