-
Notifications
You must be signed in to change notification settings - Fork 22
Add tenant app catalog & add/remove site app catalog. Closes #360 #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tenant app catalog & add/remove site app catalog. Closes #360 #453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to manage tenant and site app catalogs by allowing creation and removal via CLI commands. Key changes include:
- Registration and implementation of new commands for adding a tenant app catalog, adding a site app catalog, and removing a site app catalog.
- Updates to UI components in the CommandPanel to trigger these new commands.
- Addition of new context keys and command constants to support the new functionality.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/services/actions/CliActions.ts | Added new functions for adding/removing app catalogs and command registration. |
src/panels/CommandPanel.ts | Updated command panel UI to support the new app catalog commands. |
src/constants/ContextKeys.ts | Introduced a new context key for missing an app catalog. |
src/constants/Commands.ts | Added new command constants for app catalog actions. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/panels/CommandPanel.ts:212
- The context key for the tenant app catalog node ('sp-tenant-app-catalog-url') differs from the site app catalog key ('sp-app-catalog-url'); please confirm that this naming distinction is intentional and document the rationale if needed.
new ActionTreeItem(tenantAppCatalogUrl.replace(origin, '...'), '', { name: 'globe', custom: false }, showExpandTreeIcon, 'vscode.open', `${Uri.parse(tenantAppCatalogUrl)}/AppCatalog`, 'sp-tenant-app-catalog-url', undefined,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicodecleyre Aweomse work 👏👏👏👏
I tested it out locally and I have one feed regarding the removal flow we could recheck before we proceed.
Also added some tiny comments to the code
Also for remove I think it would be best to use the trash
icon
@nicodecleyre we just had another minor release due to SPFx version update. May I kindly ask you to rebase before we proceed |
@nicodecleyre can you provide some update on this PR? Is there anything I may help you with or needs more clarity to proceed? |
637b7c6
to
d7103a3
Compare
… and enhance form customizer setup
6476ec7
to
e6293fd
Compare
Soooooo, i did a little oopsie woopsie and totally broke the other PR 😅
🎯 Aim
This feature adds the possibility to add a tenant app catalog of it doesn't exist and the possibility to add or remove a site app catalog
📷 Result
✅ What was done
🔗 Related issue
Closes: #360