Add Messaging to Diffing Force Unwrap
#860
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevillco
changed the title
Diffing Force Unwrap
|
Hey Connor! I was just running into this due to a misconfigured Git LFS installation, and was thinking it would be nice if this function would fall back to decoding the data as a String and logging it, because it would make the failure so much more obvious at a glance. It could even do an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consuming projects can hit the affected force unwrap if there is something wrong with the comparison image file, or if the image file is being stored in
git lfs. I thought I would offer to include some messaging here. Open to any feedback.