rescale grad norm tol in line search

Author: maxpaik16

src/polysolve/nonlinear/Solver.cpp

@@ -246,9 +246,8 @@ namespace polysolve::nonlinear
         m_line_search = line_search::LineSearch::create(params, m_logger);
         solver_info["line_search"] = params["line_search"]["method"];
         m_line_search->use_grad_norm_tol = params["line_search"]["use_grad_norm_tol"];
-        m_line_search->use_grad_norm_tol *= characteristic_length;
         m_line_search->rel_interpolation_accuracy_tol = params["rel_grad_norm_tol"];
-        m_line_search->rel_interpolation_accuracy_tol *= 1e2;
+        // m_line_search->rel_interpolation_accuracy_tol *= 1e2;
         m_line_search->norm_type = params["norm_type"];
     }
 

src/polysolve/nonlinear/Solver.hpp

@@ -117,6 +117,7 @@ namespace polysolve::nonlinear
             m_stop_rescaled.relGradNorm = m_stop.relGradNorm;
             m_stop_rescaled.relXDelta = m_stop.relXDelta;
             m_stop_rescaled.newtonDecrement = m_stop.newtonDecrement * objFunc.energy_norm_rescaling(norm_type);
+            m_line_search->grad_norm_rescaling = objFunc.grad_norm_rescaling(norm_type);
         }
 
         /// @brief Stopping criteria

src/polysolve/nonlinear/line_search/LineSearch.cpp

@@ -138,7 +138,7 @@ namespace polysolve::nonlinear::line_search
             return step_size;
 
         // TODO: Fix this
-        const bool use_grad_norm = objFunc.grad_norm(initial_grad, norm_type) < use_grad_norm_tol;
+        const bool use_grad_norm = objFunc.grad_norm(initial_grad, norm_type) < use_grad_norm_tol * grad_norm_rescaling;
         const double starting_step_size = step_size;
 
         // ----------------------

src/polysolve/nonlinear/line_search/LineSearch.hpp

@@ -74,6 +74,7 @@ namespace polysolve::nonlinear::line_search
         double classical_line_search_time;
 
         double use_grad_norm_tol = -1;
+        double grad_norm_rescaling = 1;
         bool try_interpolating_step;
         double rel_interpolation_accuracy_tol = 0;
         std::string norm_type = "Euclidean";