Fix profile pane sizing #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenholligan
force-pushed
the
hh/fix-profile-pane-sizing
branch
from
d9d2c92 to
8ea2cb0
Compare
Seems like `dynamicWidth` is no longer needed...
polyipseity
force-pushed
the
hh/fix-profile-pane-sizing
branch
from
c768221 to
fc686d3
Compare
|
@haydenholligan It works, but I have found there is an easier way. Could you see the latest commit I have just pushed to your PR also works for you? At least it looks good to me. :D |
doesn't seem to :( this is on fc686d3 
and after checking out back to 8ea2cb0 and reloading, I get this 
Not sure how our setups are different... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes profile pane sizing.
Notes
I vibe coded this and am a mobile developer by trade and hence don't really know if this is correct or ideal, but does fix the problem and can at least be handed off if it can't be merged :D
Screenshots - Edit profiles modal
Screenshots - Edit profile details modal