Skip to content

Add "Disable" option for super key #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2024
Merged

Add "Disable" option for super key #573

merged 2 commits into from
Sep 9, 2024

Conversation

jasonrhansen
Copy link
Contributor

Implements #472

@git-f0x
Copy link
Contributor

git-f0x commented Sep 8, 2024

Should the super-key text be changed to "Super key action", since it can seem like the Super key is disabled, rather than the action it performs on press?

@jasonrhansen
Copy link
Contributor Author

@git-f0x I agree that it's a bit confusing the way it is, and would be more clear if changed to "Super key action".

@mmstick mmstick merged commit df43c94 into pop-os:master Sep 9, 2024
3 checks passed
@mmstick
Copy link
Member

mmstick commented Sep 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drakulix Drakulix Drakulix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonrhansen @git-f0x @mmstick @Drakulix