Skip to content

Conversation

git-f0x
Copy link
Contributor

@git-f0x git-f0x commented Sep 9, 2024

This adds the 3 interface density options from the designs: Comfortable, Compact and Spacious.
Should be tested alongside pop-os/libcosmic#603.

@TheESN
Copy link

TheESN commented Sep 10, 2024

Can you show screenshots with examples of these settings please?

@git-f0x
Copy link
Contributor Author

git-f0x commented Sep 10, 2024

The changes aren't as extensive as they should be, since a lot of things aren't yet using the variables, and this should possibly change other things as well, like the headerbar height (edit: it seems the header bars already have some density variables in the code, so I might be able to do something) or NavBar width (though not sure if the NavBar will be manually resizable in the future).
But here's a comparison of Files with the current values (Comfortable), and Compact (but as mentioned, the exact values are currently arbitrary):
screenshot-2024-09-10-13-04-41
screenshot-2024-09-10-13-04-47

@git-f0x git-f0x force-pushed the interface-density branch 3 times, most recently from 934f6b6 to 99d4db9 Compare September 13, 2024 23:18
@git-f0x git-f0x closed this Sep 13, 2024
@git-f0x git-f0x reopened this Sep 13, 2024
@git-f0x git-f0x force-pushed the interface-density branch 6 times, most recently from 1d72500 to 3b17eb4 Compare September 20, 2024 23:31
@git-f0x git-f0x force-pushed the interface-density branch 2 times, most recently from 48bcd0f to e344ba8 Compare September 23, 2024 17:15
@git-f0x git-f0x marked this pull request as ready for review September 23, 2024 17:26
@git-f0x
Copy link
Contributor Author

git-f0x commented Sep 23, 2024

This is pretty much ready, as far as the Settings side is concerned. Could possibly be merged with the sections.insert(interface_density()), line being commented out, or wait until everything in libcosmic and apps is polished.
Though merging as is would enable easier testing of what needs tweaks for all COSMIC components, but would introduce something that is a work in progress to users (maybe a disclaimer in the section title that says that it's a work in progress could be used).

Also makes the vertical space under the header use `space_m`, so that it changes its size with density.
@mmstick
Copy link
Member

mmstick commented Sep 23, 2024

I think interface density should be part of Experimental Settings for now.

@git-f0x
Copy link
Contributor Author

git-f0x commented Sep 23, 2024

I'll try to fix some App Library issues when Spacious, and then I'll try moving it to the Context drawer (above or below icon themes?).

@mmstick
Copy link
Member

mmstick commented Sep 23, 2024

I'll do some testing. Perhaps we don't need it in experimental settings if it's already working well.

@git-f0x
Copy link
Contributor Author

git-f0x commented Sep 23, 2024

It looks slightly ugly sub-optimal in some cases, but when apps update their libcosmic version, there shouldn't be many things that are cut off or broken. I haven't found anything like that, other than in the App Library, and App Tray (my PR in applets fixes this).

@mmstick
Copy link
Member

mmstick commented Sep 23, 2024

It seems good enough to me.

@mmstick mmstick merged commit 9269f9a into pop-os:master Sep 23, 2024
3 checks passed
@mmstick
Copy link
Member

mmstick commented Sep 23, 2024

Thanks!

@git-f0x
Copy link
Contributor Author

git-f0x commented Sep 23, 2024

I'll work on fixing the App Library, so there isn't missing text on group buttons when Spacious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants