WIP Use subsurfaces for screenshots UI #155
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ids1024
force-pushed
the
screenshot-subsurfaces
branch
from
83e9811 to
ac77249
Compare
ids1024
force-pushed
the
screenshot-subsurfaces
branch
from
ac77249 to
8d402fe
Compare
Should also be able to use an `image::ImageBuffer` wrapping shm memory without a copy when no transform is applied. But this doesn't do that.
ids1024
force-pushed
the
screenshot-subsurfaces
branch
from
8d402fe to
1f85977
Compare
|
There have been some subsurfaces fixes in iced since this, and as far as I can tell it doesn't have issues anymore. Need to update it to use the right background. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #153.
This seems to help a lot with performance. It needs to be updated to use the right images for background subsurfaces (probably by sharing code with cosmic-bg), but it also has some issue where sometimes one output doesn't show the background subsurface? That seems to be avoided by disabling the
needs_sortingtest in iced_winit, but that can lead to protocol errors reordering subsurfaces...