Skip to content

Conversation

@FBruzzesi
Copy link
Contributor

Summary

Follow up from the disclaimer section in #736

summary > For pyarrow backed tbl_data, `data_color` the code would end up breaking a few lines down the line when performing the follow operation:
column_vals = data_table[col][row_pos].to_list()

In fact, slicing with a list on a chunked array raises

*** TypeError: 'list' object cannot be interpreted as an integer

I wanted this PR to be atomic enough to solve one issue. I can follow up on this other one

Checklist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually checked a few vs pandas/polars, but more eyes the better

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.45%. Comparing base (654757a) to head (657eacf).

Files with missing lines Patch % Lines
great_tables/_tbl_data.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files          47       47           
  Lines        5558     5571   +13     
=======================================
+ Hits         5083     5095   +12     
- Misses        475      476    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


@get_rows.register
def _(ser: PdSeries, indexes: list[int]) -> PdSeries:
return ser.iloc[indexes]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was intended to use index location in the first place but the issue never arise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant