-
Notifications
You must be signed in to change notification settings - Fork 111
fix: Address slicing for pyarrow array in data_color
#741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually checked a few vs pandas/polars, but more eyes the better
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 47 47
Lines 5558 5571 +13
=======================================
+ Hits 5083 5095 +12
- Misses 475 476 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| @get_rows.register | ||
| def _(ser: PdSeries, indexes: list[int]) -> PdSeries: | ||
| return ser.iloc[indexes] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was intended to use index location in the first place but the issue never arise?
Summary
Follow up from the disclaimer section in #736
summary
> For pyarrow backed tbl_data, `data_color` the code would end up breaking a few lines down the line when performing the follow operation:In fact, slicing with a list on a chunked array raises
I wanted this PR to be atomic enough to solve one issue. I can follow up on this other one
Checklist