Use read-kbd-macro to make playback consistent

Had some issues, especially with characters like TAB not being interpreted
correctly.  This lead to a lengthy confirmation of a lot of behavior, ulimately
switching to `read-kbd-macro' and getting rid of the motivating issue without
much of a fight.

As a result, no translation is used and we are back at a more straightforward world.

Author: psionic-k

NEWS.org

@@ -28,7 +28,7 @@ Fixing bugs and filling some gaps in new features.
 - Keyboard macro backward steps are implemented
 - ~dslide-deck-forward~ no longer no-ops in some circumstances
 - kmacro action properly skips over non-matching directions when both forward and backward elements are present in a slide
-- 🚧 kmacro transcription of =M-RET= and =M-DEL= is now correct.  There are likely more events that don't round trip nicely from ~last-kbd-macro~ through ~key-description~ and back through ~kbd~.  *File issues*.
+- 🚧 kmacro playback of =M-<return>= and =M-<backspace>= and others is now correct.  There are likely more events that don't round trip nicely from ~last-kbd-macro~ through ~key-description~ and back through ~read-kbd-macro~.  *File issues*.
 * v0.6.0 Fighting Spam 💌
 - There is less markup (especially for babel)
 - Old actions are easier to use

dslide.el

@@ -2031,7 +2031,7 @@ Optional NO-DIRECTION will match unlabelled kmacros."
               (params (dslide-read-plist value)))
     (let ((events (or (plist-get params :events)
                       (if-let ((keys (plist-get params :keys)))
-                          (kbd keys)
+                          (read-kbd-macro keys)
                         (error "No keys or events at %s"
                                (without-restriction
                                  (line-number-at-pos
@@ -2046,14 +2046,14 @@ Optional NO-DIRECTION will match unlabelled kmacros."
 
 (cl-defmethod dslide-backward ((obj dslide-action-kmacro))
   (when dslide--kmacro-timer
-    (user-error "Dslide keboard macro already running"))
+    (user-error "Dslide keyboard macro already running"))
   (when-let* ((keyword (dslide-section-previous
                         obj 'keyword (dslide--kmacro-predicate 'backward)))
               (value (org-element-property :value keyword))
               (params (dslide-read-plist value)))
     (let ((events (or (plist-get params :events)
                       (if-let ((keys (plist-get params :keys)))
-                          (kbd keys)
+                          (read-kbd-macro keys)
                         (error "No keys or events at %s"
                                (without-restriction
                                  (line-number-at-pos
@@ -2084,7 +2084,10 @@ some other input event and quit."
     (if (eq last-input last-input-event)
         (if (length> events index)
             (let ((k (aref events index)))
-              (setq unread-command-events (list k))
+              (setq unread-command-events (if unread-command-events
+                                              (append unread-command-events
+                                                    (cons k))
+                                            (cons k)))
               (setq dslide--kmacro-timer
                     (run-with-timer
                      (dslide--laplace-jitter frequency jitter)
@@ -3124,14 +3127,6 @@ for commands without visible side effects."
   (unless dslide--kmacro-transcribe-mark
     (dslide-kmacro-transcribe-quit))
   (when-let ((macro last-kbd-macro))
-    ;; TODO I have forgotten the full list of events that can be recorded in
-    ;; `last-kbd-macro' but do not properly round-trip through
-    ;; `key-description' and back through `kbd'.  Pretty sure it's small.
-    (cl-loop for i from 0 below (length macro)
-             do (let ((key (aref macro i)))
-                  (pcase key
-                    ('M-return (aset macro i 134217741))
-                    ('M-backspace (aset macro i 134217855)))))
     ;; TODO seems like kmacro-end-macro is smart enough that we don't need to
     ;; check this
     (if (eq macro dslide--kmacro-transcribe-last)

test/macro.org

@@ -29,10 +29,24 @@ This is the best thing since 🔪🍞
 
 # Go forward with no direction
 #+dslide_kmacro: :keys "M-x n o d i r e c t i o n"
+* Play Funky
+#+begin_comment
+This macro is interpreted by ~kbd~ to a string, which will fail if used as a key sequence vector.
+#+end_comment
+#+dslide_kmacro: :keys "<tab>"
+- The content here will be folded when the macro plays successfully
 * COMMENT Closed Conversion
-Record something using =M-RET= and =M-DEL=.
+Record something using =M-<return>= and =M-<backspace>=.
 
-# M-RET test
-#+dslide_kmacro: :keys "M-> M-RET"
+# M-<return> test
+#+dslide_kmacro: :keys "M-> M-<return>"
 
 # Plays back after this point
+* Recording Strange Events
+- M-<return>
+- M-<backspace>
+- <backspace>
+- <return>
+...possibly many more
+# weird keys
+#+dslide_kmacro: :keys "M-<return> M-<backspace> a a a <backspace> <backspace> <backspace> <return> <return> <return> a a"