Update to v1.2.1-rc.1 commit 152b6b6

.github/workflows/cli.yml

@@ -45,32 +45,34 @@ jobs:
         run: |
           cargo install --force --locked --path .
 
-      - name: check build consistency
-        working-directory: examples/ecc
-        run: |
-          cargo openvm build
-          mv openvm/app.vmexe app1.vmexe
-          cargo openvm build
-          cmp app1.vmexe openvm/app.vmexe || (echo "Build is not deterministic!" && exit 1)
-
       - name: Build and run book examples
         working-directory: examples
         run: |
+          set -e
           for dir in */; do
             if [ -f "${dir}Cargo.toml" ]; then
               echo "Building ${dir%/}"
               cd "$dir"
-              cargo openvm build && cargo openvm run
+              cargo openvm build
+              cargo openvm run
               cd ..
             fi
           done
 
+      - name: check build consistency
+        working-directory: examples/ecc
+        run: |
+          cargo openvm build
+          mv target/openvm/release/ecc-example.vmexe app1.vmexe
+          cargo openvm build
+          cmp app1.vmexe target/openvm/release/ecc-example.vmexe || (echo "Build is not deterministic!" && exit 1)
+
       - name: Run app-level CLI commands
         working-directory: crates/cli
         run: |
           export RUST_BACKTRACE=1
           cargo build
-          cargo run --bin cargo-openvm -- openvm keygen --config ./example/app_config.toml --output app.pk --vk-output app.vk
+          cargo run --bin cargo-openvm -- openvm keygen --config ./example/app_config.toml --output-dir .
 
       - name: Run CLI tests
         working-directory: crates/cli

.github/workflows/extension-tests.yml

@@ -76,8 +76,6 @@ jobs:
           FEATURE_ARGS=""
           if [[ "${{ matrix.extension.name }}" == "pairing" ]]; then
             FEATURE_ARGS="--features=bn254,bls12_381,halo2curves"
-          elif [[ "${{ matrix.extension.name }}" == "ecc" ]]; then
-            FEATURE_ARGS="--features=k256,p256"
           fi
           cargo nextest run --cargo-profile=fast $FEATURE_ARGS --no-tests=pass
 

.github/workflows/guest-lib-tests.yml

@@ -0,0 +1,77 @@
+name: Guest Library Tests
+
+on:
+  push:
+    branches: ["main"]
+  pull_request:
+    branches: ["**"]
+    paths:
+      - "crates/circuits/**"
+      - "crates/vm/**"
+      - "extensions/**"
+      - "guest-libs/**"
+      - "Cargo.toml"
+      - ".github/workflows/guest-lib-tests.yml"
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
+  cancel-in-progress: true
+
+env:
+  CARGO_TERM_COLOR: always
+  OPENVM_FAST_TEST: "1"
+
+jobs:
+  integration-tests:
+    strategy:
+      matrix:
+        crate:
+          - { name: "sha2", path: "sha2" }
+          - { name: "keccak256", path: "keccak256" }
+          - { name: "ff_derive", path: "ff_derive" }
+          - { name: "k256", path: "k256" }
+          - { name: "p256", path: "p256" }
+          - { name: "ruint", path: "ruint" }
+          - { name: "pairing", path: "pairing" }
+      # Ensure tests run in parallel even if one fails
+      fail-fast: false
+
+    runs-on:
+      - runs-on=${{ github.run_id }}
+      - runner=64cpu-linux-arm64
+      - tag=crate-${{ matrix.crate.name }}
+      - extras=s3-cache
+
+    steps:
+      - uses: runs-on/action@v1
+      - uses: actions/checkout@v4
+      - uses: dorny/paths-filter@v3
+        id: filter
+        with:
+          filters: |
+            - "crates/circuits/**"
+            - "crates/vm/**"
+            - "extensions/**"
+            - "guest-libs/${{ matrix.crate.path }}/**"
+            - ".github/workflows/guest-lib-tests.yml"
+      - name: Skip if no changes
+        if: steps.filter.outputs.matched == 'false'
+        run: |
+          echo "No relevant changes, skipping tests."
+          exit 0
+
+      - uses: dtolnay/rust-toolchain@stable
+      - uses: Swatinem/rust-cache@v2
+        with:
+          cache-on-failure: true
+      - uses: taiki-e/install-action@nextest
+
+      - name: Run ${{ matrix.crate.name }} guest library tests
+        working-directory: guest-libs/${{ matrix.crate.path }}
+        run: |
+          rustup component add rust-src --toolchain nightly-2025-02-14
+          FEATURE_ARGS=""
+          if [[ "${{ matrix.crate.name }}" == "pairing" ]]; then
+            FEATURE_ARGS="--features=bn254,bls12_381"
+          fi
+          cargo nextest run --cargo-profile=fast $FEATURE_ARGS --no-tests=pass

.github/workflows/lints.yml

@@ -23,7 +23,7 @@ jobs:
 
       - uses: codespell-project/actions-codespell@v2
         with:
-          skip: Cargo.lock,./book/pnpm-lock.yaml,*.txt,./crates/toolchain/openvm/src/memcpy.s,./crates/toolchain/openvm/src/memset.s,./audits/*.pdf,
+          skip: Cargo.lock,./book/pnpm-lock.yaml,*.txt,./crates/toolchain/openvm/src/memcpy.s,./crates/toolchain/openvm/src/memset.s,./audits/*.pdf,./guest-libs/ruint/*
           ignore_words_file: .codespellignore
 
       - uses: dtolnay/rust-toolchain@stable
@@ -43,9 +43,10 @@ jobs:
 
       - name: Run clippy
         run: |
-          # list of features generated using:
-          # echo -e "\033[1;32mAll unique features across workspace:\033[0m" && cargo metadata --format-version=1 --no-deps | jq -r '.packages[].features | to_entries[] | .key' | sort -u | sed 's/^/• /'
-          cargo clippy --all-targets --all --tests --features "aggregation bench-metrics bls12_381 bn254 default entrypoint evm-prove evm-verify export-getrandom export-libm function-span getrandom halo2-compiler halo2curves heap-embedded-alloc k256 jemalloc jemalloc-prof nightly-features panic-handler parallel rust-runtime static-verifier std test-utils unstable" -- -D warnings
+          # list of all unique features across workspace generated using:
+          # cargo metadata --format-version=1 --no-deps | jq -r '.packages[].features | to_entries[] | .key' | sort -u | tr '\n' ' ' && echo ""
+          # (exclude mimalloc since it conflicts with jemalloc)
+          cargo clippy --all-targets --all --tests --features "aggregation bench-metrics bls12_381 bn254 build-binaries default entrypoint evm-prove evm-verify export-intrinsics export-libm function-span getrandom-unsupported halo2-compiler halo2curves heap-embedded-alloc jemalloc jemalloc-prof nightly-features panic-handler parallel profiling rust-runtime static-verifier std test-utils" -- -D warnings
           cargo clippy --all-targets --all --tests --no-default-features --features "mimalloc" -- -D warnings
 
       - name: Run fmt, clippy for guest
@@ -56,16 +57,13 @@ jobs:
             if [ -f "$crate_path/Cargo.toml" ]; then
               echo "Running cargo fmt, clippy for $crate_path"
               cargo +nightly fmt --manifest-path "$crate_path/Cargo.toml" --all -- --check
-              if [[ "$crate_path" == *"extensions/ecc/tests/programs"* ]]; then
-                echo "Running cargo clippy with k256 and p256 features for $crate_path"
-                cargo clippy --manifest-path "$crate_path/Cargo.toml" --all-targets --features "std k256 p256" -- -D warnings
-              elif [[ "$crate_path" == *"extensions/pairing/tests/programs"* ]]; then
+              if [[ "$crate_path" == *"guest-libs/pairing/tests/programs"* ]]; then
                 echo "Running cargo clippy with openvm_pairing_guest::bn254 feature for $crate_path"
                 cargo clippy --manifest-path "$crate_path/Cargo.toml" --all-targets --features "std bn254" -- -D warnings
                 echo "Running cargo clippy with openvm_pairing_guest::bls12_381 feature for $crate_path"
                 cargo clippy --manifest-path "$crate_path/Cargo.toml" --all-targets --features "std bls12_381" -- -D warnings
-              elif [[ "$crate_path" == *"extensions/"* ]]; then
-                echo "Running cargo clippy for $crate_path"
+              elif [[ "$crate_path" == *"extensions/"* || "$crate_path" == *"guest-libs/"* ]]; then
+                echo "Running cargo clippy with std feature for $crate_path"
                 cargo clippy --manifest-path "$crate_path/Cargo.toml" --all-targets --features "std" -- -D warnings
               else
                 echo "Running cargo clippy for $crate_path"

CHANGELOG.md

@@ -0,0 +1,19 @@
+# Changelog
+
+## v1.1.2 (2025-05-08)
+
+- The solidity verifier contract no longer has any awareness of the OpenVM patch version. `{MAJOR_VERSION}.{MINOR_VERSION}` is the minimum information necessary to identify the verifier contract since any verifier contract changes will be accompanied by a minor version bump.
+
+## v1.1.1 (2025-05-03)
+
+- Adds `OpenVmHalo2Verifier` generation to the SDK which is a thin wrapper around the original `Halo2Verifier` contract exposing a more user-friendly interface.
+- Updates the CLI to generate the new `OpenVmHalo2Verifier` contract during `cargo openvm setup`.
+- Removes the ability to generate the old `Halo2Verifier` contract from the SDK and CLI.
+- Changes the `EvmProof` struct to align with the interface of the `OpenVmHalo2Verifier` contract.
+- Formats the verifier contract during generation for better readability on block explorers.
+- For verifier contract compilation, explicitly sets the `solc` config via standard-json input for metadata consistency.
+
+## v1.1.0 (2025-05-02)
+
+### Security Fixes
+- Fixes security vulnerability [OpenVM allows the byte decomposition of pc in AUIPC chip to overflow](https://github.com/advisories/GHSA-jf2r-x3j4-23m7)