fix sum #6
Merged
fix sum #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoalt
commented
Jun 2, 2025
|
|
||
| // open every quotient chunk at zeta | ||
| let num_chunks = quotient_degrees.iter().sum::<u8>() as usize; | ||
| let num_chunks = quotient_degrees.iter().map(|x| *x as u32).sum::<u32>() as usize; |
There was a problem hiding this comment.
Since we may have lots of autoprecompiles, the sum of their max degrees may overflow u8
pacheco
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure this is the best fix but it's the easiest without deeper changes.