Remove useless ReportNode locale report and set tests locale default to stabilize report node tests

alicecaron · alicecaron · commit d3c060ad6633 · 2025-05-07T09:26:07.000+02:00
Signed-off-by: CARON Alice &lt;alice.caron@rte-france.com&gt;
diff --git a/src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowEurostagTutorialExample1Test.java b/src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowEurostagTutorialExample1Test.java
@@ -31,6 +31,7 @@
 
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
+import java.util.Locale;
 
 import static com.powsybl.openloadflow.util.LoadFlowAssert.*;
 import static org.junit.jupiter.api.Assertions.*;
@@ -58,6 +59,7 @@ class AcLoadFlowEurostagTutorialExample1Test {
 
     @BeforeEach
     void setUp() {
+        Locale.setDefault(Locale.US);
         network = EurostagFactory.fix(EurostagTutorialExample1Factory.create());
         genBus = network.getBusBreakerView().getBus("NGEN");
         bus1 = network.getBusBreakerView().getBus("NHV1");
diff --git a/src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowReportTest.java b/src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowReportTest.java
@@ -27,9 +27,11 @@
 import com.powsybl.openloadflow.network.*;
 import com.powsybl.openloadflow.util.LoadFlowAssert;
 import com.powsybl.openloadflow.util.report.PowsyblOpenLoadFlowReportResourceBundle;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
+import java.util.Locale;
 import java.util.Set;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -40,6 +42,11 @@
  */
 class AcLoadFlowReportTest {
 
+    @BeforeEach
+    void setup() {
+        Locale.setDefault(Locale.US);
+    }
+
     @Test
     void testEsgTutoDetailedNrLogsLf() throws IOException {
         Network network = EurostagFactory.fix(EurostagTutorialExample1Factory.create());
diff --git a/src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowShuntTest.java b/src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowShuntTest.java
@@ -24,6 +24,7 @@
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
+import java.util.Locale;
 
 import static com.powsybl.openloadflow.util.LoadFlowAssert.*;
 import static org.junit.jupiter.api.Assertions.*;
@@ -55,6 +56,7 @@ class AcLoadFlowShuntTest {
 
     @BeforeEach
     void setUp() {
+        Locale.setDefault(Locale.US);
         network = ShuntNetworkFactory.create();
         bus1 = network.getBusBreakerView().getBus("b1");
         bus2 = network.getBusBreakerView().getBus("b2");
diff --git a/src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowTransformerReactivePowerControlTest.java b/src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowTransformerReactivePowerControlTest.java
@@ -31,6 +31,7 @@
 
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
+import java.util.Locale;
 
 import static com.powsybl.openloadflow.util.LoadFlowAssert.*;
 import static org.junit.jupiter.api.Assertions.*;
@@ -51,6 +52,7 @@ class AcLoadFlowTransformerReactivePowerControlTest {
 
     @BeforeEach
     void setUp() {
+        Locale.setDefault(Locale.US);
         loadFlowRunner = new LoadFlow.Runner(new OpenLoadFlowProvider(new DenseMatrixFactory()));
         parameters = new LoadFlowParameters();
         parameters.setTransformerVoltageControlOn(false);
diff --git a/src/test/java/com/powsybl/openloadflow/ac/DistributedSlackOnGenerationTest.java b/src/test/java/com/powsybl/openloadflow/ac/DistributedSlackOnGenerationTest.java
@@ -35,10 +35,7 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-import java.util.EnumSet;
-import java.util.List;
-import java.util.OptionalDouble;
-import java.util.Set;
+import java.util.*;
 import java.util.concurrent.CompletionException;
 
 import static com.powsybl.openloadflow.util.LoadFlowAssert.*;
@@ -62,6 +59,7 @@ class DistributedSlackOnGenerationTest {
 
     @BeforeEach
     void setUp() {
+        Locale.setDefault(Locale.US);
         network = DistributedSlackNetworkFactory.create();
         g1 = network.getGenerator("g1");
         g2 = network.getGenerator("g2");
diff --git a/src/test/java/com/powsybl/openloadflow/ac/DistributedSlackOnLoadTest.java b/src/test/java/com/powsybl/openloadflow/ac/DistributedSlackOnLoadTest.java
@@ -31,6 +31,7 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
+import java.util.Locale;
 import java.util.concurrent.CompletionException;
 
 import static com.powsybl.openloadflow.util.LoadFlowAssert.*;
@@ -56,6 +57,7 @@ class DistributedSlackOnLoadTest {
 
     @BeforeEach
     void setUp() {
+        Locale.setDefault(Locale.US);
         network = DistributedSlackNetworkFactory.createNetworkWithLoads();
         l1 = network.getLoad("l1");
         l2 = network.getLoad("l2");
diff --git a/src/test/java/com/powsybl/openloadflow/ac/GeneratorRemoteControlPQSwitchTest.java b/src/test/java/com/powsybl/openloadflow/ac/GeneratorRemoteControlPQSwitchTest.java
@@ -37,6 +37,7 @@
 import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
+import java.util.Locale;
 
 import static org.junit.jupiter.api.Assertions.*;
 import static com.powsybl.openloadflow.util.LoadFlowAssert.*;
@@ -67,6 +68,7 @@ class GeneratorRemoteControlPQSwitchTest {
      */
     @BeforeEach
     void setUp() {
+        Locale.setDefault(Locale.US);
         network = NetworkFactory.findDefault().createNetwork("test", "java");
 
         Substation s12 = network.newSubstation()
diff --git a/src/test/java/com/powsybl/openloadflow/ac/GeneratorRemoteControlTest.java b/src/test/java/com/powsybl/openloadflow/ac/GeneratorRemoteControlTest.java
@@ -30,6 +30,7 @@
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
+import java.util.Locale;
 
 import static com.powsybl.openloadflow.util.LoadFlowAssert.*;
 import static org.junit.jupiter.api.Assertions.*;
@@ -57,6 +58,7 @@ class GeneratorRemoteControlTest extends AbstractLoadFlowNetworkFactory {
 
     @BeforeEach
     void setUp() {
+        Locale.setDefault(Locale.US);
         network = VoltageControlNetworkFactory.createWithGeneratorRemoteControl();
         s = network.getSubstation("s");
         b1 = network.getBusBreakerView().getBus("b1");
diff --git a/src/test/java/com/powsybl/openloadflow/ac/GeneratorTargetVoltageInconsistencyTest.java b/src/test/java/com/powsybl/openloadflow/ac/GeneratorTargetVoltageInconsistencyTest.java
@@ -14,10 +14,12 @@
 import com.powsybl.openloadflow.network.impl.Networks;
 import com.powsybl.openloadflow.util.LoadFlowAssert;
 import com.powsybl.openloadflow.util.PerUnit;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
 import java.util.List;
+import java.util.Locale;
 import java.util.Optional;
 
 import static org.junit.jupiter.api.Assertions.*;
@@ -27,6 +29,11 @@
  */
 class GeneratorTargetVoltageInconsistencyTest {
 
+    @BeforeEach
+    void setup() {
+        Locale.setDefault(Locale.US);
+    }
+
     private Network createLocalInconsistentTargetVoltageNetwork() {
         Network network = Network.create("generatorLocalInconsistentTargetVoltage", "code");
         Substation s = network.newSubstation()
diff --git a/src/test/java/com/powsybl/openloadflow/ac/SecondaryVoltageControlTest.java b/src/test/java/com/powsybl/openloadflow/ac/SecondaryVoltageControlTest.java
@@ -33,6 +33,7 @@
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.util.List;
+import java.util.Locale;
 import java.util.concurrent.CompletionException;
 
 import static com.powsybl.openloadflow.util.LoadFlowAssert.*;
@@ -60,6 +61,7 @@ class SecondaryVoltageControlTest {
 
     @BeforeEach
     void setUp() {
+        Locale.setDefault(Locale.US);
         network = IeeeCdfNetworkFactory.create14();
         b4 = network.getBusBreakerView().getBus("B4");
         b6 = network.getBusBreakerView().getBus("B6");
diff --git a/src/test/java/com/powsybl/openloadflow/ac/SwitchPqPvTest.java b/src/test/java/com/powsybl/openloadflow/ac/SwitchPqPvTest.java
@@ -26,6 +26,7 @@
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
+import java.util.Locale;
 
 import static com.powsybl.openloadflow.util.LoadFlowAssert.assertVoltageEquals;
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -58,6 +59,7 @@ class SwitchPqPvTest extends AbstractLoadFlowNetworkFactory {
 
     @BeforeEach
     void setUp() {
+        Locale.setDefault(Locale.US);
         network = Network.create("switch-pq-pv-test", "code");
         Substation s = network.newSubstation()
                 .setId("s")
diff --git a/src/test/java/com/powsybl/openloadflow/dc/DcLoadFlowTest.java b/src/test/java/com/powsybl/openloadflow/dc/DcLoadFlowTest.java
@@ -35,6 +35,7 @@
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.util.List;
+import java.util.Locale;
 import java.util.concurrent.CompletionException;
 
 import static com.powsybl.openloadflow.util.LoadFlowAssert.*;
@@ -56,6 +57,7 @@ class DcLoadFlowTest {
 
     @BeforeEach
     void setUp() {
+        Locale.setDefault(Locale.US);
         parameters = new LoadFlowParameters()
                 .setDc(true);
         parametersExt = OpenLoadFlowParameters.create(parameters)
diff --git a/src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisTest.java b/src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisTest.java
@@ -52,6 +52,7 @@
 import com.powsybl.security.monitor.StateMonitor;
 import com.powsybl.security.results.*;
 import com.powsybl.security.strategy.OperatorStrategy;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
@@ -73,6 +74,11 @@
  */
 class OpenSecurityAnalysisTest extends AbstractOpenSecurityAnalysisTest {
 
+    @BeforeEach
+    void setup() {
+        Locale.setDefault(Locale.US);
+    }
+
     @Test
     void testCurrentLimitViolations() {
         Network network = createNodeBreakerNetwork();
diff --git a/src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisWithActionsTest.java b/src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisWithActionsTest.java
@@ -37,16 +37,14 @@
 import com.powsybl.security.results.PostContingencyResult;
 import com.powsybl.security.results.PreContingencyResult;
 import com.powsybl.security.strategy.OperatorStrategy;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
 
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.List;
-import java.util.Set;
+import java.util.*;
 import java.util.concurrent.CompletionException;
 import java.util.stream.Stream;
 
@@ -59,6 +57,11 @@
  */
 class OpenSecurityAnalysisWithActionsTest extends AbstractOpenSecurityAnalysisTest {
 
+    @BeforeEach
+    void setup() {
+        Locale.setDefault(Locale.US);
+    }
+
     @Test
     void testDcEquationSystemUpdater() {
         Network network = VoltageControlNetworkFactory.createWithShuntSharedRemoteControl();
diff --git a/src/test/java/com/powsybl/openloadflow/sensi/AcSensitivityAnalysisReportTest.java b/src/test/java/com/powsybl/openloadflow/sensi/AcSensitivityAnalysisReportTest.java
@@ -19,11 +19,13 @@
 import com.powsybl.openloadflow.util.report.PowsyblOpenLoadFlowReportResourceBundle;
 import com.powsybl.sensitivity.SensitivityAnalysisParameters;
 import com.powsybl.sensitivity.SensitivityFactor;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
 import java.util.Collections;
 import java.util.List;
+import java.util.Locale;
 import java.util.Set;
 import java.util.stream.Collectors;
 
@@ -34,6 +36,11 @@
  */
 class AcSensitivityAnalysisReportTest extends AbstractSensitivityAnalysisTest {
 
+    @BeforeEach
+    void setup() {
+        Locale.setDefault(Locale.US);
+    }
+
     @Test
     void testEsgTuto() throws IOException {
         Network network = EurostagFactory.fix(EurostagTutorialExample1Factory.create());
diff --git a/src/test/java/com/powsybl/openloadflow/util/ReportsTest.java b/src/test/java/com/powsybl/openloadflow/util/ReportsTest.java
@@ -9,6 +9,7 @@
 
 import com.powsybl.commons.report.ReportNode;
 import com.powsybl.commons.test.PowsyblCoreTestReportResourceBundle;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import java.util.Locale;
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -18,6 +19,11 @@
  */
 class ReportsTest {
 
+    @BeforeEach
+    void setup() {
+        Locale.setDefault(Locale.US);
+    }
+
     @Test
     void useReportWithFranceLocaleTest() {
         ReportNode reportNode = ReportNode.newRootReportNode()
diff --git a/src/test/resources/i18n/reports_en.properties b/src/test/resources/i18n/reports_en.properties
