Skip to content

Add switch actions in Fast DC Security Analysis #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 76 commits into from
May 21, 2025

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Dec 13, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: p-arvy <pierre.arvy@artelys.com>
…ngine

Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
…rrent tap

Signed-off-by: p-arvy <pierre.arvy@artelys.com>
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/dc/fastdc/WoodburyEngine.java
#	src/main/java/com/powsybl/openloadflow/sa/WoodburyDcSecurityAnalysis.java
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
@p-arvy

This comment was marked as resolved.

Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Copy link

p-arvy and others added 8 commits February 25, 2025 14:44
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Hadrien-Godard and others added 2 commits April 10, 2025 08:37
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
p-arvy and others added 5 commits April 11, 2025 10:52
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
Hadrien-Godard
Hadrien-Godard previously approved these changes Apr 15, 2025
/**
* Returns true if the given contingency and operator strategy actions potentially break connectivity.
* This is determined with a "worst case" sensitivity-criterion. If the criterion is not verified, there is no connectivity break.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is exactly this "worst-case" sensitivity criterion ? I'm not sure what is meant here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that isGroupOfElementsBreakingConnectivity is a heuristic that may return true when connectivity is not acutally broken, and to minimize this risk you should not provide switches that are going to be open ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means that if the criterion is verified then there might be a connectivity break. If it is not verified then we are sure there is no connectivity break. It is a conservative approach. @p-arvy , if I am wrong on this point, correct me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's exactly it @Hadrien-Godard.

Signed-off-by: Hadrien <hadrien.godard@artelys.com>
Hadrien-Godard
Hadrien-Godard previously approved these changes May 12, 2025
Copy link

@vidaldid-rte vidaldid-rte merged commit e127832 into main May 21, 2025
8 checks passed
@vidaldid-rte vidaldid-rte deleted the switching-actions-in-fast-dc-sa branch May 21, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants