Add parameter to define min nominal voltage for unrealistic state check #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
vidaldid-rte
changed the title
src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
…ameter Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
SylvestreSakti
previously approved these changes
Apr 11, 2025
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
SylvestreSakti
previously approved these changes
May 15, 2025
jeandemanged
previously approved these changes
May 19, 2025
There was a problem hiding this comment.
good for me, if you could fix this small sonar issue it would be perfect:
https://sonarcloud.io/project/issues?sinceLeakPeriod=true&issueStatuses=OPEN%2CCONFIRMED&pullRequest=1217&id=com.powsybl%3Apowsybl-open-loadflow&open=AZYAuiscp-HZOhEi_R5D
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
vidaldid-rte
dismissed stale reviews from jeandemanged and SylvestreSakti
via
119edb0
|
SylvestreSakti
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
In order to get stricter value for min and max realistic voltage, we need to define a minimal voltage level for which the realistic check applies.
What is the current behavior?
The simulation is interrupted if any bus has a voltage outside of [minRealisticVoltage, maxRealisticVoltage]
What is the new behavior (if this is a feature change)?
The simulation is interrupted only if a bus in a voltage level with a nominal voltage higher higher than minNominalVoltageUnrealisticStateCheck is outside of [minRealisticVoltage, maxRealisticVoltage]
Does this PR introduce a breaking change or deprecate an API?
==> No because the default value is kept to 0, and [minRealisticVoltage, maxRealisticVoltage] are kept with very loose values.
Maybe we should provider better values and break compatibility ?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: